Fix deploying to Windows machines #280
Conversation
|
I added some more commits that got deploying to a windows machine working again, it seems it had been broken for a good while. Seems just like small stuff to me. I only tested Shell executor runners on windows, I'll likely run some docker-windows executor jobs with this soon and can fix those if there's anything different. |
alexdelifer
changed the title
… automatically useful for UI testing where the gitlab-runner.exe needs to be running as a process on the desktop in order to launch GUI processes properly.
|
I've successfully tested this role in my playbook that was previously running on v1.6.45 where the windows runner still worked. I'll test the docker windows runners either this afternoon or tomorrow. I've also added a little check for "gitlab_runner_windows_start_runner" which defaults to true like macos, so only people who toggle it are affected. |
| @@ -17,8 +17,8 @@ | |||
| registered_gitlab_runner_names: "{{ registered_gitlab_runner_names + [json_item['msg']] }}" | |||
| vars: | |||
| json_item: "{{ item | from_json }}" | |||
| loop: "{{ registered_runners_json_result.stderr.split('\n') }}" | |||
| loop: "{{ registered_runners_json_result.stderr_lines }}" | |||
There was a problem hiding this comment.
According to this documentation https://docs.ansible.com/ansible/latest/collections/ansible/windows/win_command_module.html
There is no such field as stderr_lines.
Can you confirm that the documentation is wrong and the field is indeed there?
There was a problem hiding this comment.
I pulled that from here
And it indeed works, when it was using the split('\n') thing there was a trailing newline/whitespace, which led to a blank {{ item }} and the task failing the when clause.
I think this might be one of those ansible "it works everywhere" kinda things.
There was a problem hiding this comment.
I'm not 1000% sure, but this implies you can expect stderr_lines to always be present.
https://docs.ansible.com/ansible/latest/reference_appendices/common_return_values.html#stderr-lines
Probably just a case of the ansible community windows missing some docs on things they consider to be "expected"
There was a problem hiding this comment.
Upstream PR :)
ansible-collections/ansible.windows#550
|
I can also confirm my docker-windows machines are successfully deployed and ready in gitlab with the changes from this branch. |
It seems the current implementation breaks if there are no configured runners, this brings the window configuration in line with the other Unix configurations.
It seems to work on my side when testing just this included file.