Configure host with --host #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. using --host 127.0.0.1 restricts incoming connections to those from localhost
stylewarning
requested changes
Apr 17, 2019
| @@ -34,6 +34,11 @@ | |||
| :optional t | |||
| :documentation "start a QVM server") | |||
|
|
|||
| (("host") | |||
| :type string | |||
| :optional t | |||
There was a problem hiding this comment.
can we use :initial-value here, or w/e the kw is, and nix the globvar?
| :type string | ||
| :optional t | ||
| :documentation "host on which to start the QVM server") | ||
|
|
||
| (("port" #\p) | ||
| :type integer |
app/src/entry-point.lisp
Outdated
| @@ -190,18 +195,20 @@ Copyright (c) 2016-2019 Rigetti Computing.~2%") | |||
| (or *num-workers* (max 1 (qvm:count-logical-cores)))) | |||
| nil) | |||
|
|
|||
| (defparameter *host-address* "0.0.0.0") | |||
| (defparameter *default-host-address* "0.0.0.0") | |||
app/src/entry-point.lisp
Outdated
| (check-type port (or null (integer 0 65535)) | ||
| "The port must be between 0 and 65535.") | ||
| (when (null host) |
app/src/entry-point.lisp
Outdated
| (check-type port (or null (integer 0 65535)) | ||
| "The port must be between 0 and 65535.") | ||
| (when (null host) | ||
| (setf host *default-host-address*)) | ||
| (when (null port) |
stylewarning
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. using --host 127.0.0.1 restricts incoming connections to those
from localhost