Permalink
Browse files

acu72727 - code review response

  • Loading branch information...
1 parent acf5714 commit c6563e5ba587543a1110d9a0187e4e41c7fe4b8b @danielrife danielrife committed Apr 16, 2013
Showing with 3 additions and 3 deletions.
  1. +3 −3 lib/right_http_connection.rb
@@ -170,11 +170,11 @@ def get_proxy_info_for_env
return parsed_uri.host, parsed_uri.port, parsed_uri.user, parsed_uri.password
else
@logger.warn "Invalid protocol in ENV['HTTP_PROXY'] URI = #{ENV['HTTP_PROXY'].inspect} expecting 'http' got #{parsed_uri.scheme.inspect}"
- return nil, nil, nil, nil
+ return
end
rescue Exception => e
- @logger.warn "Error parsing ENV['HTTP_PROXY'] URI = #{ENV['HTTP_PROXY'].inspect}, with exception: #{e.message}"
- return nil, nil, nil, nil
+ @logger.warn "Error parsing ENV['HTTP_PROXY'] with exception: #{e.message}"
+ return
end
private :get_proxy_info_for_env

3 comments on commit c6563e5

@Sergyenko
Contributor

COMPLIANCE-COMMITMESSAGE-FIXED acu72321

@rightscale-ci
Member

RS-COMPLIANCE: COMPLIANCE-COMMITMESSAGE-PASS Build: #25964(2013-06-13_20-49-39), repo: right_http_connection, branch/tag: master, sha: c6563e5, status: PASS, reason: Acunote ID is specified, not checking if it is valid because this is not a head commit. (https://rightscale.acunote.com/projects/2091/tasks/72727)

@Sergyenko
Contributor

COMPLIANCE-COMMITMESSAGE-FIXED acu72321

Please sign in to comment.