Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

acu72727 - code review response

  • Loading branch information...
commit c6563e5ba587543a1110d9a0187e4e41c7fe4b8b 1 parent acf5714
danielrife authored April 16, 2013

Showing 1 changed file with 3 additions and 3 deletions. Show diff stats Hide diff stats

  1. 6  lib/right_http_connection.rb
6  lib/right_http_connection.rb
@@ -170,11 +170,11 @@ def get_proxy_info_for_env
170 170
         return parsed_uri.host, parsed_uri.port, parsed_uri.user, parsed_uri.password
171 171
       else
172 172
         @logger.warn "Invalid protocol in ENV['HTTP_PROXY'] URI = #{ENV['HTTP_PROXY'].inspect} expecting 'http' got #{parsed_uri.scheme.inspect}"
173  
-        return nil, nil, nil, nil
  173
+        return
174 174
       end
175 175
     rescue Exception => e
176  
-      @logger.warn "Error parsing ENV['HTTP_PROXY'] URI = #{ENV['HTTP_PROXY'].inspect}, with exception: #{e.message}"
177  
-      return nil, nil, nil, nil
  176
+      @logger.warn "Error parsing ENV['HTTP_PROXY'] with exception: #{e.message}"
  177
+      return
178 178
     end
179 179
     private :get_proxy_info_for_env
180 180
 

3 notes on commit c6563e5

Sergey
Collaborator

COMPLIANCE-COMMITMESSAGE-FIXED acu72321

rightscale-ci
Collaborator

RS-COMPLIANCE: COMPLIANCE-COMMITMESSAGE-PASS Build: #25964(2013-06-13_20-49-39), repo: right_http_connection, branch/tag: master, sha: c6563e5, status: PASS, reason: Acunote ID is specified, not checking if it is valid because this is not a head commit. (https://rightscale.acunote.com/projects/2091/tasks/72727)

Sergey
Collaborator

COMPLIANCE-COMMITMESSAGE-FIXED acu72321

Please sign in to comment.
Something went wrong with that request. Please try again.