Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

refs #13307 - remove ssl logging stuff due it's useless #13

Merged
merged 1 commit into from

3 participants

@litvinovsky

Initially we decide to remove ssl logging because there are too
many logs connected with that. We don't need to log this stuff,
because if there is problem with authorization then the server
will return appropriate status code in the response.

@litvinovsky litvinovsky refs #13307 - remove ssl logging stuff due it's useless
Initially we decide to remove ssl logging because there are too
many logs connected with that. We don't need to log this stuff,
because if there is problem with authorization then the server
will return appropriate status code in the response.
4b3b136
@konstantin-dzreev
Collaborator

Looks good. If it works as expected then I'm OK with it ;)

@vdmgolub
Collaborator

Looks good to me. But can't merge due to access restrictions :)

@konstantin-dzreev konstantin-dzreev merged commit c03daef into rightscale:release4.3_gw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 10, 2012
  1. @litvinovsky

    refs #13307 - remove ssl logging stuff due it's useless

    litvinovsky authored
    Initially we decide to remove ssl logging because there are too
    many logs connected with that. We don't need to log this stuff,
    because if there is problem with authorization then the server
    will return appropriate status code in the response.
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 6 deletions.
  1. +0 −6 lib/right_http_connection.rb
View
6 lib/right_http_connection.rb
@@ -310,12 +310,6 @@ def start(request_params)
# List of error codes: http://www.openssl.org/docs/apps/verify.html
code = x509_store_ctx.error
msg = x509_store_ctx.error_string
- #debugger
- if code == 0
- @logger.info "##### Certificate verification passed. #####"
- else
- @logger.warn("##### #{@server} certificate verify failed: #{msg}")
- end
if request_params[:fail_if_ca_mismatch] && code != 0
false
else
Something went wrong with that request. Please try again.