Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monkey patch to preserve GIT_ env variables #13

Merged
merged 1 commit into from Aug 13, 2013

Conversation

nobodyzzz
Copy link
Contributor

Current any cookbook launched with the dev_cookbooks tag is broken if the git chef provider is used at all.

This tag causes cookbooks to be downloaded via the git rubygem. This rubygem unfortunately sets 3 GIT_ environment variables that will screw up any subsequent shell out to git: https://github.com/schacon/ruby-git/blob/master/lib/git/lib.rb#L655-L657

Details

@ghost
Copy link

ghost commented Aug 12, 2013

Looks good to me; I want Scott Messier to have a quick look, to ensure that this doesn't break our server-side usage of the scraper. (It should not.)

@ghost
Copy link

ghost commented Aug 12, 2013

Scott says this is OK.

kevin-bockman pushed a commit that referenced this pull request Aug 13, 2013
…cookbook_tag

Monkey patch to preserve GIT_ env variables
@kevin-bockman kevin-bockman merged commit 99385e1 into master Aug 13, 2013
@smessier smessier deleted the ivory_13_09_acu113740_fix_dev_cookbook_tag branch March 8, 2016 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants