Skip to content

Minify / Less on Windows don't work #14

Closed
JoshSchreuder opened this Issue Jun 12, 2012 · 2 comments

3 participants

@JoshSchreuder

Hi.

The subprocess calls to minify and less don't work on Windows (at least on mine).

Did a bit of digging and adding ',Shell=True' to the call seems to work.
(see here: http://stackoverflow.com/questions/3022013/windows-cant-find-the-file-on-subprocess-call)

eg.
subprocess.check_call(shlex.split('uglifyjs -o static/js/min/scripts-{0}.min.js static/js/combined.js'.format(settings.COMPRESS_REVISION_NUMBER)), shell=True)

Not sure how this affects Mac / Linux systems.

Not overly knowledgable with Git or I'd do a pull request, sorry.

@owenwilliams

Sorry, did you put the command above in when in python? I have the same problem.

@owenwilliams

I found that you need to amend as above in the "Compress.py" file, and it works great. Don't copy the above code, though. That seemed to break it for me. Just amend it.

@rigoneri rigoneri added a commit that closed this issue Jun 26, 2012
@rigoneri Added windows issue info on readme for reference. Closes #14 since it…
… doesn't appear to be an issue on other OSs.
bf4cdab
@rigoneri rigoneri closed this in bf4cdab Jun 26, 2012
@derekhardwick derekhardwick pushed a commit that referenced this issue Aug 12, 2012
@rigoneri Added windows issue info on readme for reference. Closes #14 since it…
… doesn't appear to be an issue on other OSs.
648ea7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.