Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calculation for {force: false, offset: nonZero} #139

Merged
merged 2 commits into from Sep 10, 2019

Conversation

@nburlett
Copy link
Contributor

commented Apr 11, 2019

Undo the pre-applied offset when calculating whether the element is already
visible (and therefore we shouldn't scroll).

Fixes #138

nburlett and others added 2 commits Apr 11, 2019
Fix calculation for {force: false, offset: nonZero}
Undo the pre-applied offset when calculating whether the element is already
visible (and therefore we shouldn't scroll).

Fixes #138

@rigor789 rigor789 merged commit f01ce23 into rigor789:master Sep 10, 2019

1 of 5 checks passed

deploy/netlify Deploy preview processing.
Details
Header rules No header rules processed
Details
Pages changed 7 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
@rigor789

This comment has been minimized.

Copy link
Owner

commented Sep 10, 2019

🎉 This PR is included in version 2.16.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rigor789 rigor789 added the released label Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.