Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix force:false issue with viewport scrolling #150

Merged
merged 2 commits into from Sep 10, 2019

Conversation

@brophdawg11
Copy link
Contributor

commented Jul 23, 2019

Currently, if an item is out of the bottom of the viewport and we attempt to scroll to it with force:false, it will decide that the item is already in the container (body) and therefore will not scroll. I have a small reproduction of this at https://codesandbox.io/s/vue-scrollto-issue-sx56v.

When not specifying a container, and thus defaulting to body, the container should be treated as the viewport, otherwise it will never scroll downward to the element. I think this is what #55 was getting at as well so I didn't file a separate issue.

This also fixes #140 since I happened to notice that while making this change.

@rigor789 rigor789 merged commit 14eb022 into rigor789:master Sep 10, 2019

2 of 5 checks passed

Header rules No header rules processed
Details
Pages changed 7 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
deploy/netlify Deploy preview ready!
Details
@rigor789

This comment has been minimized.

Copy link
Owner

commented Sep 10, 2019

🎉 This PR is included in version 2.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.