Permalink
Switch branches/tags
Commits on Jun 18, 2012
Commits on Jun 15, 2012
  1. Fixes SC.ArrayController's Array orderBy to work for more than a sing…

    publickeating committed Jun 15, 2012
    …le Array item.
    
    - It was replacing the object with the value, so subsequent iterations would fail to find the key on the object (now a value).
  2. Adds unit test to prove that SC.ArrayController's Array orderBy doesn…

    publickeating committed Jun 15, 2012
    …'t work for more than a single Array item. The following commit will fix this.
  3. Changes SC.ArrayController orderBy syntax to 'key ASC' or 'key DESC',…

    publickeating committed Jun 15, 2012
    … not 'ASC key' or 'DESC key'.
    
    - SC.Query's and MySQL's ordering syntax are both 'key DIR' and so SC.ArrayController's syntax should be the same.
  4. Adds tests that will verify that orderBy syntax should be 'key ASC' o…

    publickeating committed Jun 15, 2012
    …r 'key DESC', not 'ASC key' or 'DESC key'. The following commit will rectify this failure.
    
    - SC.Query's and MySQL's ordering syntax are both 'key DIR' and so SC.ArrayController's syntax should be the same.
  5. Removed layer check from SC.TemplateCollectionView when cleaning up o…

    Wesley Workman committed with publickeating Mar 8, 2012
    …ld items to ensure that childViews are cleaned up when the view is removed from the DOM.
Commits on Jun 14, 2012
  1. Changing the extract parameters and route function to use the deparam…

    tstachl committed with publickeating Dec 21, 2011
    … function. Left the build the route for loop so it'll use the url-decoded values from the params obj instead of the original ones.
  2. Merge pull request #779 from edtsech/778-order-by

    publickeating committed Jun 14, 2012
    Add ability to comparing records through associations.
Commits on Jun 13, 2012
  1. Adds a note for future developers to be aware of the inconsistency of…

    publickeating committed Jun 13, 2012
    … the returned value of missing properties on local storage.
  2. Merge pull request #799 from dliau/master

    publickeating committed Jun 13, 2012
    This test on user_defaults shows that readDefault does not return a default value if one is predefined in Firefox 13.  However, this works in Chrome.
    
    [publickeating] Note: In at least Firefox 13, window.localStorage returns 'null' for undefined properties.
  3. Merge pull request #789 from sproutcore/team/publickeating/nested_rec…

    publickeating committed Jun 13, 2012
    …ord_leak_squash
    
    Fixes memory leaks using child records (aka nested records)
  4. test for readDefault function on Firefox 13 showing that it doesnt re…

    dliau committed Jun 13, 2012
    …turn a default value if the value is not available. Working in Chrome
Commits on Jun 11, 2012
  1. Merge pull request #791 from sproutcore/team/tim-evans/segmented-view…

    tim-evans committed Jun 11, 2012
    …-leak
    
    Clean up item content observers on segmented views
Commits on Jun 6, 2012
Commits on Jun 5, 2012
  1. Merge pull request #792 from dcporter/master

    publickeating committed Jun 5, 2012
    Moving key_bindings from desktop to core_foundation where it is used.
  2. Moving key_bindings to core_foundation so it can be with views/view/k…

    dcporter committed Jun 5, 2012
    …eyboard (apparently the only thing that uses it).
Commits on Jun 1, 2012
  1. SegmentedView - Remove observers from items when they are removed fro…

    Will Mitchell committed with tim-evans May 31, 2012
    …m the view, prevents a case where a removed item calls itemContentDidChange and puts itself back in a segment
Commits on May 29, 2012
  1. Check which method to use.

    edtsech committed May 29, 2012
  2. Merge pull request #786 from dcporter/master

    publickeating committed May 29, 2012
    Clicking on a content-less collection view results in a thrown error.
  3. Merge pull request #758 from sproutcore/team/workmanw/treecontroller-…

    publickeating committed May 29, 2012
    …selectionoptions-persistence
    
    Added bindings between the tree controller and it's tree item observer to keep the selection options in sync
  4. Fixes createNestedRecord for child records without primary keys.

    publickeating committed May 29, 2012
    - The previous version had some broken code, such as checking for the existence of id, although it is not set anywhere previously or passed to the function and creating an existingId variable for no purpose.  It also wrapped most of the function in a run loop, but I'm certain it's not necessary.
    - The previous version would create a new record even if the child record has no primary key, which would auto-generate a new primary key and thus a new store key each time that same child record needed to be re-accessed.  It also did extra work fixing up the store by having to manipulate the id after creation.
    - This version generates a re-usable id upfront for child records that don't have a primary key value.  This means that the id is unique to that child record and if the child record is unloaded and reloaded, even though it doesn't have a primary key, it will still get the same generated id and thus, get the same store key in the store, preventing the store from creating new objects and leaking the caches on the old child record.
    - See previous unit tests checking that child records without primary keys keep or lose their id and storeKey properly when manipulated.
  5. Fixes memory leak in the store when removing or replacing child records.

    publickeating committed May 29, 2012
    - The first time that you access a child record, the store updates four caches:  parentRecords (parentStoreKeys => [childStoreKeys]), childRecords (childStoreKeys => parentStoreKeys), records (SC.Record instances), dataHashes (SC.record backing attributes).
    - Previously, if you set the child record to null or unloaded and reloaded the parent record or set the child record to a new child record and the child record doesn't have a primary key, the store would create duplicates on all these hashes, resulting in a memory leak.
    - Now each time that you set the value of the child record on the parent, it clears the old child record caches in the store.
    - See previous tests to prove the memory leak, by modifying the child record and checking the number of properties in the store's caches.
  6. Fixes unit tests for child records that don't have primary keys.

    publickeating committed May 29, 2012
    - Child records should not need a primary key, since they are just part of the parent record and so they should not be modified to have a 'guid' property and should return null to childRecord.get('guid').
  7. Adds tests proving that replacing child views or unloading reloading …

    publickeating committed May 29, 2012
    …records with child views leaks objects in the store.
Commits on May 26, 2012
  1. Merge pull request #787 from rykov/master

    etgryphon committed May 26, 2012
    Fix Desktop vs Touch for experimental SC.ScrollView
  2. Actually fixes customized classNameBindings. (ex. classNameBindings: …

    publickeating committed May 26, 2012
    …['isWorking:wkg'] )
    
    - Accidentally committed testing version.
  3. Adds unit tests proving that customized classNameBindings (ex. 'isAct…

    publickeating committed May 26, 2012
    …ive:active') don't work. Also fixes the other unit tests in this file that had misplaced parentheses.	.