Commits on Jul 4, 2012
  1. @fabpot

    merged branch fabpot/classloader-optim (PR #4729)

    Commits
    -------
    
    3f9e8ff [ClassLoader] made ClassCollectionLoader::load() automatically include class dependencies
    6f4d281 [ClassLoader] added missing support for PHP 5.4 traits
    
    Discussion
    ----------
    
    Classloader optimization
    
    The first commit fixes support for PHP 5.4 trait.
    
    The second one does several things:
    
     * it optimizes the recent merge so that the reflection class instance is only loaded once;
     * we use the fact that we now get all class dependencies to automatically add all class dependencies to the map.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-07-03T17:26:46Z
    
    I've updated to take into accounts traits.
    
    ---------------------------------------------------------------------------
    
    by bamarni at 2012-07-04T11:58:57Z
    
    great job 👍
    
    I can't see it in the diff as this part hasn't changed, but somewhere in the autoReload block there is :
    ```
    if ($meta[1] != $classes) {
        $reload = true;
    }
    ```
    
    It should be array_unique($classes), otherwise the file would be perpetually regenerated in autoReload mode when the input contains duplicate, because they're implicitely removed when dumping the files.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-07-04T13:20:04Z
    
    @bamarni I've added an `array_unique` call at the top (this bug existed before by the way).
    fabpot committed Jul 4, 2012
  2. @fabpot

    [ClassLoader] made ClassCollectionLoader::load() automatically includ…

    …e class dependencies
    fabpot committed Jul 3, 2012
  3. @fabpot

    merged branch Tobion/patch-3 (PR #4720)

    Commits
    -------
    
    51b610f [Profiler] fix typehint
    
    Discussion
    ----------
    
    [Profiler] fix typehint
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-07-03T10:23:25Z
    
    The profiler only works with Twig anyway.
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-07-03T10:29:18Z
    
    Right. But why does he have this error: symfony@f47b9a6#commitcomment-1532164
    
    And since the class only uses methods of the general interface, I thought this makes it more reliable.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-07-03T10:37:26Z
    
    It was unrelated and I fixed that problem already.
    fabpot committed Jul 4, 2012
  4. @fabpot

    merged branch shieldo/patch-7 (PR #4741)

    Commits
    -------
    
    6751c87 [Profiler] fixed a couple of minor typos in a test
    
    Discussion
    ----------
    
    [Profiler] fixed a couple of minor typos in a test
    fabpot committed Jul 4, 2012
  5. @shieldo
  6. @fabpot
  7. @fabpot

    merged branch Tobion/query (PR #4735)

    Commits
    -------
    
    c40a4e5 [HttpFoundation] fix query string normalization
    f9ec2ea refactored test method
    0880174 [HttpFoundation] added failing tests for query string normalization
    
    Discussion
    ----------
    
    [HttpFoundation] fix query string normalization
    
    This fixes the query string normalization. There were several problems in it (see test cases that I added).
    The main issue, that first catched my eye, was that the query string was urldecoded before it was exploded by `=`. See old code: `explode('=', rawurldecode($segment), 2);`. This means an encoded `=` (`%3D`) would falsely be considered a separator and thus lead to complete different parameters. The fixed test case is at `pa%3Dram=foo%26bar%3Dbaz&test=test`.
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-07-04T02:21:25Z
    
    cc @simensen considering your PR 4711
    fabpot committed Jul 4, 2012
  8. @fabpot

    merged branch Tobion/request (PR #4737)

    Commits
    -------
    
    d37003e [HttpFoundation] small fixes in Request
    
    Discussion
    ----------
    
    [HttpFoundation] small fixes in Request
    
    phpdoc fixes,
    making http_build_query explicit
    fixing query string of '0', that was ignored.
    
    Unfortunately this '0' problematic is omnipresent because PHP makes it so easy to get wrong (as it is converted to boolean false). I don't know how often I fixed such issue already.
    fabpot committed Jul 4, 2012
  9. @fabpot

    merged branch Tobion/prevsession (PR #4736)

    Commits
    -------
    
    4d0ae1f [HttpFoundation] refactored hasPreviousSession
    
    Discussion
    ----------
    
    [HttpFoundation] refactored hasPreviousSession
    fabpot committed Jul 4, 2012
  10. @Tobion
  11. @Tobion
  12. @Tobion
  13. @Tobion

    refactored test method

    Tobion committed Jul 4, 2012
  14. @Tobion
Commits on Jul 3, 2012
  1. @fabpot

    merged branch Seldaek/processfinder (PR #4731)

    Commits
    -------
    
    45219ef [Process] Add default xampp path to the list of possible paths to check
    28e1313 [Process] Clean-up/simplify code
    56f473a [Process] Add extra dirs argument to the executable finder to allow searching more dirs
    
    Discussion
    ----------
    
    ExecutableFinder changes
    
    It cleans up stuff a bit and adds a guess for xampp users that wouldn't have php in their path
    fabpot committed Jul 3, 2012
  2. @fabpot

    [ClassLoader] fixed typo

    fabpot committed Jul 3, 2012
  3. @fabpot

    merged branch vicb/profiler (PR #4727)

    Commits
    -------
    
    eda439f [EventDataCollector] Display a better message when no events have been recorded
    6b87981 [TimeDataCollector] Do not throw an exception when no events are recorded
    
    Discussion
    ----------
    
    [Profiler] Better support for collector in a production env
    
    relates to #3706.
    
    With this PR it is possible to:
    - enable only the profiler in a production environment - the wdt being disabled you have to switch to the development environment to inspect the collected data,
    - enable both the profiler and the wdt in a production environment (the use case form #3706).
    
    @jmikola would this solve your use case ?
    fabpot committed Jul 3, 2012
  4. @fabpot

    merged branch bschussek/issue4480 (PR #4732)

    Commits
    -------
    
    45d967e [Form] Fixed: Empty forms can be compound too
    
    Discussion
    ----------
    
    [Form] Fixed: Empty forms can be compound too
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #4480
    Todo: -
    fabpot committed Jul 3, 2012
  5. @webmozart
  6. @fabpot
  7. @fabpot

    fixed unit tests

    fabpot committed Jul 3, 2012
  8. @Seldaek
  9. @Seldaek
  10. @fabpot
  11. @Seldaek
  12. @vicb
  13. @vicb
  14. @fabpot

    merged branch vicb/templates (PR #4723)

    Commits
    -------
    
    aef7663 [FrameworkBundle] Create a dedicated template filename parser
    
    Discussion
    ----------
    
    [FrameworkBundle] Create a dedicated template filename parser
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: yes
    Symfony2 tests pass: yes
    
    related to #3116
    fabpot committed Jul 3, 2012
  15. @fabpot

    merged branch jmikola/patch-2 (PR #4728)

    Commits
    -------
    
    0fe56e6 [Config] Fix comment typo
    
    Discussion
    ----------
    
    [Config] Fix comment typo
    fabpot committed Jul 3, 2012
  16. @jmikola

    [Config] Fix comment typo

    jmikola committed Jul 3, 2012
  17. @fabpot

    merged branch mageekguy/master (PR #4725)

    Commits
    -------
    
    6155583 Remove bug in locale management in listener.
    
    Discussion
    ----------
    
    Remove bug in locale listener
    fabpot committed Jul 3, 2012
  18. Remove bug in locale management in listener.

    Frédéric Hardy committed Jul 3, 2012
  19. @fabpot

    merged branch vicb/auto_start (PR #4724)

    Commits
    -------
    
    c5470b0 [Session] Removes references to the deprecated 'auto_start' setting
    
    Discussion
    ----------
    
    [Session] Removes references to the deprecated 'auto_start' setting
    
    fix #4721
    fabpot committed Jul 3, 2012
  20. @vicb
  21. @vicb