Added support for multiple events at the same time. #25

Open
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@PVince81

Before this fix, pasting text into a field with the mouse (right click +
paste) didn't trigger the event.
Some other plugins like clearableTextField
(https://github.com/ono/clearable_text_field/) only trigger the "change"
event which didn't refresh the search.

Vincent Petry added some commits Jun 30, 2011

Vincent Petry
Added support for multiple events at the same time.
Before this fix, pasting text into a field with the mouse (right click +
paste) didn't trigger the event.
Some other plugins like clearableTextField
(https://github.com/ono/clearable_text_field/) only trigger the "change"
event which didn't refresh the search.
@richardjohnjensen

This comment has been minimized.

Show comment Hide comment
@richardjohnjensen

richardjohnjensen Aug 22, 2011

Using your patch and the latest clearable_text_field, I can paste into the selector to trigger the quicksearch. Cool!
Did you have to modify the clearable_text_field to remove the quicksearch filter?

I was looking for a solution when I ran against your pull using the same components, but cannot get the clear text to reset the search.

Using your patch and the latest clearable_text_field, I can paste into the selector to trigger the quicksearch. Cool!
Did you have to modify the clearable_text_field to remove the quicksearch filter?

I was looking for a solution when I ran against your pull using the same components, but cannot get the clear text to reset the search.

@PVince81

This comment has been minimized.

Show comment Hide comment
@PVince81

PVince81 Aug 23, 2011

Hello Richard,

Thanks for merging my changes.

I didn't have to modify clearable_text_field for that. Clicking on the cross seems to trigger the quicksearch events automatically.

One problem though is that if you paste text into the field while it's empty, the clearable_text_field's icon won't appear.
To fix this I made a similar change (adding events) here: ono/clearable_text_field#3

Cheers,

Vincent

----- Mail original -----
De : richardjohnjensen reply@reply.github.com
À : PVince81@yahoo.fr
Cc :
Envoyé le : Lundi 22 Août 2011 23h55
Objet : Re: [quicksearch] Added support for multiple events at the same time. (#25)

Using your patch and the latest clearable_text_field, I can paste into the selector to trigger the quicksearch. Cool!
Did you have to modify the clearable_text_field to remove the quicksearch filter?

I was looking for a solution when I ran against your pull using the same components, but cannot get the clear text to reset the search.

Reply to this email directly or view it on GitHub:
#25 (comment)

Hello Richard,

Thanks for merging my changes.

I didn't have to modify clearable_text_field for that. Clicking on the cross seems to trigger the quicksearch events automatically.

One problem though is that if you paste text into the field while it's empty, the clearable_text_field's icon won't appear.
To fix this I made a similar change (adding events) here: ono/clearable_text_field#3

Cheers,

Vincent

----- Mail original -----
De : richardjohnjensen reply@reply.github.com
À : PVince81@yahoo.fr
Cc :
Envoyé le : Lundi 22 Août 2011 23h55
Objet : Re: [quicksearch] Added support for multiple events at the same time. (#25)

Using your patch and the latest clearable_text_field, I can paste into the selector to trigger the quicksearch. Cool!
Did you have to modify the clearable_text_field to remove the quicksearch filter?

I was looking for a solution when I ran against your pull using the same components, but cannot get the clear text to reset the search.

Reply to this email directly or view it on GitHub:
#25 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment