Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typehole.tNaN #7

Closed
rikukissa opened this issue May 17, 2021 · 4 comments
Closed

typehole.tNaN #7

rikukissa opened this issue May 17, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@rikukissa
Copy link
Owner

It seems if you add a new typehole that doesn't have the "typehole.t[number] format, the next typehole you'll add with cmd+. will cause the name if the whole to be tNaN.

I think a possible solution for this would be to just treat the method labels as strings

@andrew-ironforge
Copy link

Looking at this a bit more... (From Reddit!).

I am still running into the issue. Attached is a screen recording.

Screen.Recording.2021-05-17.at.2.39.50.PM.mov

I have no other type holes in the project:
Screen Shot 2021-05-17 at 2 40 46 PM

@andrew-ironforge
Copy link

If I reload the window, the issue does not occur. So it seems to me that perhaps there's some kind of caching issue that is resolved when the editor is reloaded? Clearing out all type holes from the project doesn't fix it... a reload is required.

@rikukissa
Copy link
Owner Author

👋 It must have been Typehole's internal state and the overly naive implementation for figuring out an id for the next hole based on the previous ids. If one of the previous ids were not possible to parse to an integer, then previous + 1 would be NaN. I'll make it so that all typehole ids are treated as strings and come up with another way for figuring out new unique ids.

Thanks for the video and a good issue description. Much appreciated

@rikukissa rikukissa added the bug Something isn't working label May 18, 2021
@rikukissa
Copy link
Owner Author

Should now be fixed in 1.5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants