Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore keywords in regular pragmas #332

Closed
develop7 opened this issue Nov 28, 2018 · 13 comments
Closed

Ignore keywords in regular pragmas #332

develop7 opened this issue Nov 28, 2018 · 13 comments

Comments

@develop7
Copy link
Contributor

@develop7 develop7 commented Nov 28, 2018

Repro:

  • Consider following source fragment:
    {-# OPTIONS_GHC -fno-warn-type-defaults #-}

Expected: type is not highlighted as keyword

Instead:
image

@rikvdkleij
Copy link
Owner

@rikvdkleij rikvdkleij commented Nov 28, 2018

Thanks for reporting!

Yes, I also so noticed that but that not find good solution.

Maybe @ice1000 knows how to solve this?

Loading

@ice1000
Copy link
Contributor

@ice1000 ice1000 commented Nov 28, 2018

I'm not sure. I'll try this weekend (struggling with my essay 😭).

Loading

@ice1000
Copy link
Contributor

@ice1000 ice1000 commented Nov 28, 2018

Fixed.

Loading

@develop7
Copy link
Contributor Author

@develop7 develop7 commented Nov 30, 2018

@ice1000 no it's not:
image

Loading

@ice1000
Copy link
Contributor

@ice1000 ice1000 commented Nov 30, 2018

??????

Loading

@ice1000
Copy link
Contributor

@ice1000 ice1000 commented Nov 30, 2018

image

Can I see your color settings?
It's here:

image

Loading

@ice1000
Copy link
Contributor

@ice1000 ice1000 commented Nov 30, 2018

Well, it's really weird. I'm having the same issue, let me investigate more

Loading

@ice1000
Copy link
Contributor

@ice1000 ice1000 commented Nov 30, 2018

Seems that the property "bold" cannot be undone -- I can make other contents bold, but I can't make bold text unbold. Why? Oh my god.

Loading

@ice1000
Copy link
Contributor

@ice1000 ice1000 commented Nov 30, 2018

a

Loading

@ice1000
Copy link
Contributor

@ice1000 ice1000 commented Nov 30, 2018

Trying to set the value explicitly in the config file

Loading

@ice1000
Copy link
Contributor

@ice1000 ice1000 commented Nov 30, 2018

Not working. Oh no!

Loading

@ice1000
Copy link
Contributor

@ice1000 ice1000 commented Nov 30, 2018

Well, at least the color is no longer orange...

Loading

@ice1000
Copy link
Contributor

@ice1000 ice1000 commented Feb 17, 2019

Let's re-open this @rikvdkleij.

My local dev branch resolves this in an ideal way, I hope I can re-close this issue in the PR 😉

Loading

ice1000 added a commit to ice1k/intellij-haskell that referenced this issue Feb 17, 2019
rikvdkleij added a commit that referenced this issue Feb 17, 2019
Implement new parser, close #382, close #332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants