New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pragma/function name highlight and color settings page, move config page #334

Merged
merged 5 commits into from Nov 28, 2018

Conversation

Projects
None yet
3 participants
@ice1000
Contributor

ice1000 commented Nov 28, 2018

Fixes #332

@ice1000

This comment has been minimized.

Contributor

ice1000 commented Nov 28, 2018

@ice1000

This comment has been minimized.

Contributor

ice1000 commented Nov 28, 2018

Maybe a special highlighting for pragma should be added.

@develop7

This comment has been minimized.

develop7 commented Nov 28, 2018

Maybe a special highlighting for pragma should be added.

Makes sense, since there's whole lot of these pragmas where keywords highlighting would be useful, e.g. REWRITE, SPECIALIZE or MINIMAL.

@ice1000

This comment has been minimized.

Contributor

ice1000 commented Nov 28, 2018

image

Well it's not very well done, I may need to override the font style (bold to regular) as well.

@ice1000

This comment has been minimized.

Contributor

ice1000 commented Nov 28, 2018

A problem is, my Windows laptop has stack installed so it works well with intellij-haskell but there's no JDK and Scala SDK on it, while my Linux laptop has only cabal so it doesn't work with intellij-haskell but there's full JVM/IntelliJ plugin dev environment on it.
My process of contributing to this repo is, use my Linux laptop to modify the code, submit PR, build a zip, upload on GitHub, download and test on my Windows laptop and show screenshots to you guys...

This is very painful..

@rikvdkleij

This comment has been minimized.

Owner

rikvdkleij commented Nov 28, 2018

@ice1000 Sorry to hear it's painful. Why don't you install stack on your linux laptop?

@develop7

This comment has been minimized.

develop7 commented Nov 28, 2018

Second that, should definitely do the job.

@ice1000

This comment has been minimized.

Contributor

ice1000 commented Nov 28, 2018

@ice1000 Sorry to hear it's painful. Why don't you install stack on your linux laptop?

It's too large 😂

Well, I'm fine with it anyway. Me myself is a plugin developer -- I'm the owner of the Julia plugin.

@ice1000

This comment has been minimized.

Contributor

ice1000 commented Nov 28, 2018

@rikvdkleij What do u think of #333 ? What's actually painful is maintaining two PRs at the same time.

@rikvdkleij

This comment has been minimized.

Owner

rikvdkleij commented Nov 28, 2018

What's actually painful is maintaining two PRs at the same time.

That is easily solved 😄 Thanks!

@rikvdkleij

This comment has been minimized.

Owner

rikvdkleij commented Nov 28, 2018

Well, I'm fine with it anyway. Me myself is a plugin developer -- I'm the owner of the Julia plugin.

It's really great that you are using your experience to improve this plugin!

@ice1000

This comment has been minimized.

Contributor

ice1000 commented Nov 28, 2018

It's really great that you are using your experience to improve this plugin!

Yeah, we're all plugin developers. So we share the same goal, the same pain 😂

@ice1000 ice1000 force-pushed the ice1k:highlight-pragma branch from 43b9045 to 35c5497 Nov 28, 2018

@ice1000

This comment has been minimized.

Contributor

ice1000 commented Nov 28, 2018

Rebased! Maybe we need to provide default color settings.

@ice1000

This comment has been minimized.

Contributor

ice1000 commented Nov 28, 2018

Don't merge right now, I may want to add more syntax highlight.

@rikvdkleij

This comment has been minimized.

Owner

rikvdkleij commented Nov 28, 2018

Ok, let me know when it's finished.

@ice1000

This comment has been minimized.

Contributor

ice1000 commented Nov 28, 2018

I want to move Haskell's settings to the Languae & Framework section

@develop7

This comment has been minimized.

develop7 commented Nov 28, 2018

Makes perfect sense to me

@rikvdkleij

This comment has been minimized.

Owner

rikvdkleij commented Nov 28, 2018

I want to move Haskell's settings to the Languae & Framework section

Good idea.

@ice1000

This comment has been minimized.

Contributor

ice1000 commented Nov 28, 2018

image
I'm really really really sorry to bring this. I'm gonna fix it

@ice1000

This comment has been minimized.

Contributor

ice1000 commented Nov 28, 2018

image
U forget hoogle!

@ice1000

This comment has been minimized.

Contributor

ice1000 commented Nov 28, 2018

All set.

@ice1000

This comment has been minimized.

Contributor

ice1000 commented Nov 28, 2018

@ice1000

This comment has been minimized.

Contributor

ice1000 commented Nov 28, 2018

image

Hand-written Swing! It's aweful!
image

IntelliJ UI-Designer! It's nice!

@ice1000 ice1000 changed the title from Update pragma highlight to Update pragma/function name highlight and color settings page, move config page Nov 28, 2018

@develop7

This comment has been minimized.

develop7 commented Nov 28, 2018

U forget hoogle!

Could we not spellcheck stuff coming from external libraries instead?

@ice1000

This comment has been minimized.

Contributor

ice1000 commented Nov 28, 2018

Could we not spellcheck stuff coming from external libraries instead?

This is hard to implement, the API is inconvenient for doing this.

@develop7

This comment has been minimized.

develop7 commented Nov 28, 2018

This is hard to implement, the API is inconvenient for doing this.

Should we ask JetBrains to implement this globally instead?

@ice1000

This comment has been minimized.

Contributor

ice1000 commented Nov 28, 2018

Should we ask JetBrains to implement this globally instead?

I don't think so. It's hard to explain why if you have no idea about the IntelliJ-Platform architecture.

@ice1000

This comment has been minimized.

Contributor

ice1000 commented Nov 28, 2018

There's a chat room for plugin developers: https://gitter.im/IntelliJ-Plugin-Developers/Lobby

@ice1000

This comment has been minimized.

Contributor

ice1000 commented Nov 28, 2018

Wow!
image
image

@ice1000

This comment has been minimized.

Contributor

ice1000 commented Nov 28, 2018

Oh! My essay! 😨

@ice1000

This comment has been minimized.

Contributor

ice1000 commented Nov 28, 2018

Well, I'm not happy with this icon.
image

Maybe should keep the original haskell.png

@ice1000

This comment has been minimized.

Contributor

ice1000 commented Nov 28, 2018

image

Beautiful!

@ice1000

This comment has been minimized.

Contributor

ice1000 commented Nov 28, 2018

@rikvdkleij rikvdkleij merged commit 3d17389 into rikvdkleij:master Nov 28, 2018

@rikvdkleij

This comment has been minimized.

Owner

rikvdkleij commented Nov 28, 2018

Thanks!!

@ice1000 ice1000 deleted the ice1k:highlight-pragma branch Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment