Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new parser, close #382, close #332 #387

Merged
merged 1 commit into from Feb 17, 2019

Conversation

Projects
None yet
2 participants
@ice1000
Copy link
Contributor

commented Feb 17, 2019

No, description, provided.

But please do add more tests to ensure that originally-accepted Haskell pragmas are still accepted in this new version.

@ice1000

This comment has been minimized.

Copy link
Contributor Author

commented Feb 17, 2019

Also please check that if it breaks any completion/linting features. The AST is changed.

@rikvdkleij rikvdkleij merged commit 91add0a into rikvdkleij:master Feb 17, 2019

@rikvdkleij

This comment has been minimized.

Copy link
Owner

commented Feb 17, 2019

@ice1000

Many thanks! Your help is great!

But please do add more tests to ensure that originally-accepted Haskell pragmas are still accepted in this new version.

I will do my best 😄

Also please check that if it breaks any completion/linting features. The AST is changed.

Will so some more testing.

@rikvdkleij

This comment has been minimized.

Copy link
Owner

commented Feb 17, 2019

@ice1000
Hmm, somethings goes wrong.

When I try to enter a pragma the syntax highlighting for the whole file does weird and I can not remove tokens in the pragma.

Can you take a look?

@ice1000

This comment has been minimized.

Copy link
Contributor Author

commented Feb 17, 2019

Sounds like some real tests are needed apart from test cases.
I'll check it right now.

@rikvdkleij

This comment has been minimized.

Copy link
Owner

commented Feb 17, 2019

Thanks!

Sounds like some real tests are needed apart from test cases.

It looks your change broke some features but I have no problem with fixing that if parser and bnf are correctly working.

Also the handler which automatically enters the closing pragma is broken. I think because the pragma is now defined in the parser.
I think you forgot something because in the flex file still OPTIONS_GHC is defined while it's now in general for pragma's.

@ice1000 ice1000 deleted the ice1k:new-pragma-parser branch Feb 17, 2019

@ice1000

This comment has been minimized.

Copy link
Contributor Author

commented Feb 17, 2019

I've digged a little and it sounds like it's more rubost

@rikvdkleij

This comment has been minimized.

Copy link
Owner

commented Mar 14, 2019

@ice1000

FYI, this change broke automatically closing double quotes, fixed in 65ee527

@ice1000

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

Again?
Oh no..

@ice1000

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

Ah. I thought it's an unused lex fule. I'm sorry

@rikvdkleij

This comment has been minimized.

Copy link
Owner

commented Mar 15, 2019

@ice1000

No problem 😄 Just FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.