[controller-inputs] fixes using analog sticks as discrete inputs on controllers with poor calibration - #50
Merged
Conversation
…ontrollers with poor calibration
Owner
|
LGTM. This is a good improvement to have in general, thanks for looking into it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes my experience with my Backbone One, and possibly other controllers.
On my Backbone One's right Analog Stick, while the Y-Axis will report values up to 1.0, the X-Axis only reported up to 0.96 or so.
But because it's not the full 1.0 value, inputs coming from continuous inputs mapped to discrete ones (such as the right analog stick mapping to N64's c-buttons) would not fire at all.
Whether it's this code or a different fix, I would love a solution in Delta!
(I do not know if this is the case with all Backbone One controllers, or if mine is simply poorly calibrated, but it meant that my inputs weren't working regardless)