Jose A. Rilla rilla

Organizations

@dradis @the-cocktail
@rilla
@rilla
  • @rilla 2a62fd2
    Preparing repo for implementation
@rilla

Ok, fixed in e49e464

@rilla
  • @rilla e49e464
    Secure .to_sym from untrusted input
@rilla

Will do. Thanks!

@rilla

Actually.. shouldn't it be enough to do that for @default_options? If the validation doesn't pass (i.e. if the key is not already present in @defau…

@rilla

Ok, I understand the problem now. I think our better shot here is making @default_options into HashWithIndifferentAccess as @georgemillo suggests: …

@rilla

Well, we're just checking if @default_options contains the provided key and only then we'll update the variable... shouldn't that be safe?

@rilla

Yes.

@rilla
  • @rilla 08d2f0f
    Fix Settings#update_settings
@rilla
@rilla master is now eddaec6
@rilla
@rilla
@rilla
  • @rilla 266bd34
    Snowcrash - Style Configurations#index
@rilla
  • @rilla e5fc4ce
    Integrate Configuration view
@rilla
  • @rilla ec9ed6d
    Validate input in Settings#update_settings
@rilla
  • @rilla da0aa44
    Settings#is_default? is no longer provate so it can be used from Drad…
  • @rilla ecb199d
    Add method to allow updating settings by key-value hash
  • 1 more commit »
@rilla
@rilla
  • @rilla b14de75
    Fix precedence of dirty vs DB vs default values for settings. Also fi…
@rilla
  • @rilla 7e6d1b6
    Use new convention to set default setting values
@rilla
  • @rilla aa83a4a
    Write settings to DB as needed and track if setting values are defaul…
  • @rilla 9ea3647
    Handle ContentService instance in Dradis::Plugins::Export::Base
  • 1 more commit »
@rilla
  • @rilla 90a9d41
    Inherit from dradis-plugins BaseController
@rilla
  • @rilla 6f3d118
    Use ContenService instead of pulling contents directly via ActiveRecord
@rilla

Yup, tested and working. As you said, HtmlExport::BaseController gets instantiated every time the export task is initiated, and that's when the bas…

@rilla

Sorry, not sure about how to use ContentService in this specific instance. Could you elaborate a bit?

@rilla

Do you mean I should: a) Implement and use the all_notes method, which would retrieve all Note instances, thus ignoring the 'reporting category' lo…

@rilla

Fixed! :smile:

@rilla
  • @rilla e7e2efe
    Sort config names alphabetically
@rilla