From 529298fa274ca7e22dcbf143e39b1cd0545f4ecf Mon Sep 17 00:00:00 2001
From: Anshul Khandelwal <12948312+k-anshul@users.noreply.github.com>
Date: Wed, 26 Feb 2025 19:12:05 +0530
Subject: [PATCH] fix panic due to uri parse error

---
 runtime/pkg/rduckdb/db.go | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/runtime/pkg/rduckdb/db.go b/runtime/pkg/rduckdb/db.go
index 2b4ed48b7f3..6e3f5ce4b7b 100644
--- a/runtime/pkg/rduckdb/db.go
+++ b/runtime/pkg/rduckdb/db.go
@@ -770,7 +770,9 @@ func (d *db) openDBAndAttach(ctx context.Context, uri, ignoreTable string, read
 
 	db = sqlx.NewDb(otelsql.OpenDB(connector), "duckdb")
 	defer func() {
-		if dbErr != nil {
+		// there are too many error paths after this so closing the db in a defer seems better
+		// but the dbErr can be non nil even before function reaches this point so need to check for db is non nil
+		if dbErr != nil && db != nil {
 			_ = db.Close()
 		}
 	}()