From aa15cd4b8d0da130f8c74cee1a21dd943fbfbcc6 Mon Sep 17 00:00:00 2001 From: Qureshi Waqas <64982453+qureshiwaqas@users.noreply.github.com> Date: Wed, 14 Feb 2024 22:38:46 -0500 Subject: [PATCH 1/2] Deprecate methods for testing purposes [TrackRecordingService]: Deprecate methods for testing purposes - Added `@Deprecated` annotation to `getTrackPointCreator()` and `getTrackRecordingManager()` methods. - `since`: 14.0.0 - `forRemoval`: true These methods are deprecated for testing purposes only and are currently marked for removal. --- .../dennisguse/opentracks/services/TrackRecordingService.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java b/src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java index cbc6f8271..7d4f826f2 100644 --- a/src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java +++ b/src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java @@ -285,7 +285,7 @@ public Marker.Id insertMarker(String name, String category, String description, return trackRecordingManager.insertMarker(name, category, description, photoUrl); } - @Deprecated + @Deprecated(since = "14.0.0", forRemoval = true) @VisibleForTesting public TrackPointCreator getTrackPointCreator() { return trackPointCreator; @@ -354,4 +354,4 @@ public void onSharedPreferenceChanged(SharedPreferences sharedPreferences, @Null trackPointCreator.onSharedPreferenceChanged(sharedPreferences, key); notificationManager.onSharedPreferenceChanged(sharedPreferences, key); } -} \ No newline at end of file +} From 2e3fbd8604839ae1ff08fb10eaed458db0a5793a Mon Sep 17 00:00:00 2001 From: Qureshi Waqas <64982453+qureshiwaqas@users.noreply.github.com> Date: Fri, 16 Feb 2024 15:09:02 -0500 Subject: [PATCH 2/2] Update TrackRecordingService.java --- .../dennisguse/opentracks/services/TrackRecordingService.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java b/src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java index 7d4f826f2..44bd57f54 100644 --- a/src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java +++ b/src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java @@ -291,7 +291,7 @@ public TrackPointCreator getTrackPointCreator() { return trackPointCreator; } - @Deprecated + @Deprecated (forRemoval = false) @VisibleForTesting public TrackRecordingManager getTrackRecordingManager() { return trackRecordingManager;