Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
qcommsimmodem: Fix setting 3G preference when one of the slot is empty. #228
Conversation
|
Adding ril_sim_get_state() to ril.c is not needed: as you already have ofono_modem available in qcommsimmodem/radio-settings.c, you can call __ofono_modem_find_atom(modem, OFONO_ATOM_TYPE_SIM) and check the SIM status directly. |
|
Oh, thank you for that. I was finding way to accomplished that. I'll re-implement that code. |
|
Ok, new version pushed. |
alfonsosanchezbeato
reviewed
Feb 25, 2016
| @@ -76,6 +77,24 @@ static void qcom_msim_set_rat_cb(struct ril_msg *message, gpointer user_data) | ||
| } | ||
| } | ||
| +static void qcom_msim_do_set_rat_mode(struct ofono_radio_settings *rs, int pref | ||
| + , struct cb_data *cbd) { |
alfonsosanchezbeato
Feb 25, 2016
Contributor
Do not split the line between a variable and a comma, and also that "{" should be starting a line.
|
Looks good, there is just a formatting issue. |
peat-psuwit
added some commits
Nov 24, 2015
|
New version pushed. |
added a commit
that referenced
this pull request
Feb 25, 2016
alfonsosanchezbeato
merged commit 1d27df0
into
rilmodem:master
Feb 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
peat-psuwit commentedFeb 21, 2016
Normally, to set a slot as 3G when there are 2 SIMs in the device, radio settings must set other slot to 2G first. But if the other slot is empty, this action will fail. This PR make sure that radio settings will skip the empty slot. Along the way, I've refactored code around so that the code is cleaner.