There is no code sample for slider field type. #266

Closed
gurumark opened this Issue Mar 31, 2013 · 5 comments

Projects

None yet

4 participants

@gurumark

Slider field type is missing in demo.php. It would be very helpful if we have some sample code there.

Thanks

@gurumark

Why is it hard to get a simple response? Slider type is supported in the list but is not listed in the demo.php. Just asking for a simple improvement so that others can evaluate if this type is useful.

@rilwis rilwis added a commit that referenced this issue Apr 6, 2013
@rilwis Revamp 'slider' field. Also add its demo #266
- Add 'js_options' param to allow more control with JS
- Add 'prefix' and 'suffix' params for text value labels. Not sure these names are good. Please comment.
1713363
@rilwis
Owner

Hi,
Very sorry for this delay.

The problem is active developers here (including me) are not the person who developed this field type (if I remember correctly, that was @kaiser). That's some parts of code are not 100% clear to us.

But I've just revamped the code, and added a demo for it.

Have fun.

@djevrek
@funkedgeek funkedgeek added a commit that referenced this issue Apr 6, 2013
@rilwis Revamp 'slider' field. Also add its demo #266
- Add 'js_options' param to allow more control with JS
- Add 'prefix' and 'suffix' params for text value labels. Not sure these names are good. Please comment.
5776956
@funkedgeek
Collaborator

I'm gonna work on making this clonable

@gurumark

Thanks for working on this guys! We are testing the rest of the fields as well. It would be very helpfull if there was an approval process for the fields code before it is pulled in. Someone could check the code is compliant with the api general and some additional unit testing would be usefull as well. It will help avoid situations like this.

@rilwis rilwis closed this May 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment