Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file_advanced and image_advanced on 4.6 #678

Closed
karissademi opened this issue Oct 26, 2015 · 4 comments
Closed

file_advanced and image_advanced on 4.6 #678

karissademi opened this issue Oct 26, 2015 · 4 comments

Comments

@karissademi
Copy link

When a new file (or files) are uploaded, they do not appear in the media library pane. I'm seeing this with both the file_advanced and image_advanced metaboxes. The files do get uploaded to the media library and refreshing the page will display them as expected.

uploader
@funkatron82
Copy link
Contributor

Just noticed that myself a few days ago. Looking into how to fix this. Stay tuned

@rilwis rilwis mentioned this issue Nov 4, 2015
Closed
funkatron82 added a commit that referenced this issue Nov 11, 2015
@funkatron82
Removing filtering of already selected media in modal
23fe384 
This is to prevent a bug that stops the modal from updating when a file
is uploaded.  With this change, already selected media will appear in
the modal, but current code will prevent duplication if selected.  See
#678
@funkatron82
Copy link
Contributor

Alright, uploading should now work in the modal. The reason it wasn't working right is a bug in the media modal. When the modal is created, I filtered out media that was already selected in the field. This, unfortunately, prevented uploads from showing up in the modal browser. With this fix, files selected will show up in the modal, though the current code will prevent those files from being inserted multiple times.

@funkatron82
Copy link
Contributor

Closing this as it fixes the main issue, which is uploads in the modal.

@karissademi
Copy link
Author

Awesome. You all rock. Any eta on an official WP release with this included?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karissademi @funkatron82