Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve symbolic links with Boost.Filesystem #202

Closed
Prcuvu opened this issue Apr 26, 2018 · 3 comments
Closed

Resolve symbolic links with Boost.Filesystem #202

Prcuvu opened this issue Apr 26, 2018 · 3 comments
Assignees

Comments

@Prcuvu
Copy link
Contributor

Prcuvu commented Apr 26, 2018

This can be done by is_symlink() and read_symlink(). The only problem is whether it is necessary.

@Prcuvu
Copy link
Contributor Author

Prcuvu commented Apr 26, 2018

As reported in rime/weasel#216, user directory may be placed under a symbolic link to home directory. It may cause deployment failure if the parent symbolic link is not resolved.

@lotem
Copy link
Member

lotem commented Apr 26, 2018

It's complicated. I cannot create an instant fix.
Changes shall be made carefully.
While trying to find a resource by file name, path is constructed by concatenating each prefix and the relative path. In some places such path strings are compared, this can be error prone (no sound proof; while I wrote the code I thought it could be dangerous): if one is resolved by following symlink, the prefix will no longer match.

@eagleoflqj
Copy link
Member

No boost fs any more.

@eagleoflqj eagleoflqj closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants