feat(assets): restore high-resolution icons and fix placeholder assets#134
Merged
RUKAYAT-CODER merged 1 commit intoApr 27, 2026
Merged
Conversation
- Replaced low-res 22KB source icon and broken 70-byte placeholders with high-density 477KB assets. - Updated app.json to hard-link icon, splash, and notification paths to the restored high-res sources. - Optimized Android adaptive icon configuration by removing redundant backgroundImage in favor of backgroundColor. - Ensured all platform fields (expo.icon, expo.ios.icon, expo.android.adaptiveIcon) point to high-DPI assets to prevent App Store/Play Store rejection.
|
@zinodict121 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #127
PR: Restore High-Density App Assets and Optimize Icon Configuration
Description
This PR resolves a critical production issue where several core app assets were either missing required densities, low-resolution placeholders, or broken 70-byte files. These issues would have likely led to App Store/Play Store rejection and a poor user experience on modern high-DPI devices.
Key Changes
Asset Restoration: Recovered high-resolution image data from @3x assets to replace the low-resolution source icon (22KB) and broken placeholders (notification-icon.png, splash.png, and splash-icon.png which were only 70 bytes).
Configuration Hard-linking: Updated app.json to explicitly point all platform-specific icon and splash fields to the restored high-density assets/icon.png and assets/splash.png.
Adaptive Icon Optimization: Removed the redundant backgroundImage for Android adaptive icons in favor of the branding-consistent backgroundColor (#E6F4FE), ensuring a cleaner and more standard-compliant look.
Plugin Fixes: Updated the expo-notifications and expo-splash-screen plugin configurations to use the restored high-res assets.
Impact
Asset Quality: Core assets increased from ~70 bytes to 477KB, providing crisp visuals on all modern iPhone and Android displays.
Store Compliance: Ensures the app meets the minimum resolution requirements for iOS and Android launchers.
Android Stability: Fixed the notification-icon.png placeholder to prevent system-level "broken asset" warnings during push notifications.
Verification
Verified file sizes via terminal (assets/icon.png is now 477,884 bytes).
Validated app.json schema via npx expo config --type public.
Confirmed all paths point to the high-res sources.
Labels: assets, priority-high, bugfix