Skip to content

Conversation

@dividedby0
Copy link
Contributor

Adding hooks needed for real logger plugin

…-gci-logger-integration

# Conflicts:
#	packages/testring-logger/interfaces.d.ts
#	packages/testring-logger/src/abstract-logger-client.ts
#	packages/testring-logger/test/logger-client.spec.ts
#	packages/testring-types/src/test-run-controller/index.ts
@coveralls
Copy link

coveralls commented Jul 3, 2018

Pull Request Test Coverage Report for Build 141

  • 12 of 28 (42.86%) changed or added relevant lines in 5 files are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.6%) to 69.842%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/testring-plugin-api/src/modules/test-run-controller.ts 0 4 0.0%
packages/testring-logger/src/abstract-logger-client.ts 7 13 53.85%
packages/testring-test-run-controller/src/test-run-controller.ts 1 7 14.29%
Files with Coverage Reduction New Missed Lines %
packages/testring-child-process/src/resolve-binary.ts 1 88.0%
packages/testring-child-process/src/fork.ts 2 68.42%
packages/testring-test-utils/src/test-worker.mock.ts 2 33.33%
packages/testring-test-run-controller/src/test-run-controller.ts 3 40.54%
Totals Coverage Status
Change from base Build 131: -0.6%
Covered Lines: 902
Relevant Lines: 1137

💛 - Coveralls

@dividedby0 dividedby0 changed the title [WIP] Logger plugin integration Logger plugin integration Jul 5, 2018
@dividedby0 dividedby0 merged commit 2d28c83 into master Jul 6, 2018
@flops flops deleted the WAT-370-gci-logger-integration branch September 25, 2018 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants