fixes shell completion #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retrieving completion candidates failed if a global property getter used `require()` (i.e. `console`) because the global scope doesn't have a worker attached. this fix introduces a new method `getProperty` in `RingoWorker` class to ensure there's a worker bound to the current thread before retrieving completion candidates using `ScriptableObject.getProperty` as this method executes getter functions. other notable changes: - disable history expansion in terminal because `!` would be interpreted as backwards history search - don't limit completion candidate retrieval, as jline3 prompts if there are many of them - don't omit printing out `undefined` return values, instead print them using a light grey color, and omit executing empty lines in shell
botic
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retrieving completion candidates failed if a global property getter used
require()(i.e.console) because the global scope doesn't have a worker attached.this fix introduces a new method
getPropertyinRingoWorkerclass to ensure there's a worker bound to the current thread before retrieving completion candidates usingScriptableObject.getPropertyas this method executes getter functions.other notable changes:
!would be interpreted as backwards history searchundefinedreturn values, instead print them using a light grey color, and omit executing empty lines in shell