Added refresh token support and improved users.recentlyPlayed() (fixes #30) #31
Conversation
|
Thinking about it now, perhaps it doesn't make sense to store the refresh token in |
|
Looks like #28 should probably be merged, and then this PR can just be about |
| @@ -99,5 +99,27 @@ main() async { | |||
|
|
|||
| var relatedArtists = await spotify.artists.relatedArtists('0OdUWJ0sBjDrqHygGUXeCF'); | |||
| print('related Artists: ${relatedArtists.length}'); | |||
|
|
|||
There was a problem hiding this comment.
Please remove that change from the PR, since it's coming in with #28 😸
| @@ -52,7 +52,15 @@ abstract class SpotifyApiBase { | |||
| Future<Null> _refreshToken() async { | |||
| if (_apiToken == null || _apiToken.isExpired) { | |||
| var headers = {'Authorization': 'Basic ${_credentials.basicAuth}'}; | |||
| var body = {'grant_type': 'client_credentials'}; | |||
| var body; | |||
There was a problem hiding this comment.
Please remove that change from the PR, since it's coming in with #28 😸
|
|
||
| SpotifyApiCredentials(this.clientId, this.clientSecret); | ||
| SpotifyApiCredentials(this.clientId, this.clientSecret, [this.refreshToken = null]); |
There was a problem hiding this comment.
Please remove that change from the PR, since it's coming in with #28 😸
| throw new Exception('Cannot specify both after and before.'); | ||
| } | ||
|
|
||
| var queryParams = []; |
There was a problem hiding this comment.
Please use our existing "tools" for generating the query. We have a _buildQuery(...) method in the base class, which takes a Map and produces the query string. It also filters out keys where the values are null. For usage you can check here.
Thanks!
Right, at the moment an instance always belongs to a specific set of credentials. What's your use case? Do you run through many users and have to instantiate a lot of |
This commit adds the ability for the user to specify a refresh token to
SpotifyApiCredentials. If a refresh token is specified, it is used by_refreshToken().This commit also improves the
users.recentlyPlayed()function to allow for specifying the query parameterslimit,after, andbefore, and it now returns aFuture<Iterable<PlayHistory>>which captures theplayed_attimestamp in addition to the track.