2.3.13 - Error updating nested <virtual> tags #1512

Closed
jkol opened this Issue Jan 12, 2016 · 2 comments

Projects

None yet

3 participants

@jkol
jkol commented Jan 12, 2016

Plnkr for demo: http://plnkr.co/edit/uCm8jg3y2W2ZmGVM6bPR

Clicking updateChlidren button

Using riot-and-compiler-2-3-12.js show expected result:

4 items: 1 2 3 4
5 items: 1 2 3 4 5 

Using riot-and-compiler-2-3-13.js shows actual:

4 items: 1 2 3 4
5 items: 1 2 3 4 5
1 items: 1
2 items: 1 2 

Accompanied by error in console:

TypeError: v.parentNode is null
Tag/</<() riot-and-compiler-2-3-13.js:1553
each() riot-and-compiler-2-3-13.js:1784
Tag/<() riot-and-compiler-2-3-13.js:1552
riot.observable/</<() riot-and-compiler-2-3-13.js:130
riot.observable/onEachEvent() riot-and-compiler-2-3-13.js:49
riot.observable/<() riot-and-compiler-2-3-13.js:123
Tag/<() riot-and-compiler-2-3-13.js:1585
unmountRedundant() riot-and-compiler-2-3-13.js:1023
_each/<() riot-and-compiler-2-3-13.js:1209
riot.observable/</<() riot-and-compiler-2-3-13.js:130
riot.observable/onEachEvent() riot-and-compiler-2-3-13.js:49
riot.observable/<() riot-and-compiler-2-3-13.js:123
Tag/<() riot-and-compiler-2-3-13.js:1446
setEventHandler/dom[name]() riot-and-compiler-2-3-13.js:1652
1 riot-and-compiler-2-3-13.js:1553:9
@rsbondi rsbondi self-assigned this Jan 13, 2016
@rsbondi
Contributor
rsbondi commented Jan 13, 2016

Looks like a check here for v.parentNode && v.parentNode.removeChild(v) will fix, this code did not change but something changed with the dom

@GianlucaGuarini GianlucaGuarini added the bug label Jan 13, 2016
@rsbondi rsbondi added the fixed label Jan 17, 2016
@GianlucaGuarini
Member

fixed in riot 2.3.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment