Changing to no-reorder behaviour without a reason #1790

Closed
fernandogmar opened this Issue May 13, 2016 · 3 comments

Projects

None yet

2 participants

@fernandogmar

Help us to manage our issues by answering the following:

  1. Describe your issue:

I have spent a full morning on this: I have a loop to show a list of items, but when I change this list to show different items, it starts working as no-reorder mode.

I spent the morning checking everthing on my code, updating the version of RIOT to 2.4, even I tryed setting reorder="true"... and no way.

So the only possible answer on my mind: RIOT's bug??... so I dived a bit on the unknown code just in case I could get any clue.... and I think I was lucky when I found this line:

_mustReorder = mustReorder && item instanceof Object && !hasKeys,

no idea but item instanceof Object was returning false after changing the list in my code, so I tryed next one:

_mustReorder = mustReorder && typeof(item) === 'object' && !hasKeys,

and it worked!!

I don't know anything about the RIOT implementation, but I hope at least you can solve this soon on the code in case there is something else.

  1. Can you reproduce the issue?

Yes I can, but I cannot share the code here, and I don't know how exactly this fails to do a smaller example.

  1. On which browser/OS does the issue appear?
  2. Which version of Riot does it affect?

2.3 2.4 no idea of anyone before

  1. How would you tag this issue?
    • Question
    • [X ] Bug
    • Discussion
    • Feature request
    • Tip
    • Enhancement
    • Performance
@GianlucaGuarini
Member

Hi @fernandogmar thanks for your bug reporting. Can you drill down an example where we can test the issue? It should not be your app sourcecode but at least the we can check the list of items you are trying to loop.

@fernandogmar
fernandogmar commented May 13, 2016 edited

Hi @GianlucaGuarini ,

the thing is that the lists are really simple... and on the first list the items are instances of Object but in the second one it returns false! I have taken two screenshots of the values:

First list without problems
itemsbefore

Second list where the items fail the condition instanceOf Object:
itemsafterwhichfailscondition

Not really sure where the problem is but with typeof(item) works fine.

Thanks! and Have a nice weekend!

@GianlucaGuarini
Member

@fernandogmar ok I will test it and update riot in the next patch release thanks for reporting it

@GianlucaGuarini GianlucaGuarini added fixed and removed to verify labels May 16, 2016
@GianlucaGuarini GianlucaGuarini added a commit that closed this issue May 22, 2016
@GianlucaGuarini GianlucaGuarini closes #1790 835b693
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment