select option order position not as expected #1815

Closed
u007 opened this Issue May 30, 2016 · 4 comments

Projects

None yet

3 participants

@u007
u007 commented May 30, 2016 edited

Help us to manage our issues by answering the following:

  1. Describe your issue:

here is my tag code:

<select name="{prefix}[model_id]" class="select2 full" onchange={changed}>
        <option value="-1"></option>
        <option value={row.id} each={row, index in list}>{makers[row.maker_id].name} - {row.name}</option>
        <option value="0">Other</option>
</select>

Expected:

-1, ids.., 0 (other as last)

Actual result below:

-1, 0, ids... (other is after empty -1, but not below all the valid ids from my list
  1. On which browser/OS does the issue appear?
    firefox
  2. Which version of Riot does it affect?
    riot 2.4
  3. How would you tag this issue?
    • [*] Bug
@GianlucaGuarini
Member

can you please create a live example where the bug occurs?

@rsbondi
Contributor
rsbondi commented May 30, 2016

http://plnkr.co/edit/hm7lRj96FtfZsJoecDbD?p=preview

it started in 2.3.0 and is specific to select/option, if you change to ul/li in the example all is well

@rsbondi rsbondi added the bug label May 30, 2016
@rsbondi
Contributor
rsbondi commented May 30, 2016

need to insert here instead of append, I will fix soon.

@rsbondi rsbondi self-assigned this May 30, 2016
@u007
u007 commented May 31, 2016

@rsbondi thank you :)

@rsbondi rsbondi added fixed and removed to verify labels Jun 1, 2016
@GianlucaGuarini GianlucaGuarini pushed a commit that closed this issue Jul 3, 2016
@rsbondi rsbondi fixes #1815 3c6769d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment