Child tags always inheriting functions and properties from parent tags outside of loop #1982

Closed
ashleybrener opened this Issue Sep 15, 2016 · 5 comments

Projects

None yet

2 participants

@ashleybrener
Contributor
ashleybrener commented Sep 15, 2016 edited
  1. Describe your issue:

Child tag instances seem to be inheriting functions and properties from their parent tags all the way down the inheritance chain.

Is this a bug or by design ?

I was under the impression that only tag instances within loops inherit context from the parent in Riot 2.x.

  1. Can you reproduce the issue?

    Bug Report Template

  2. On which browser/OS does the issue appear?

Mac OSX Chrome / Safari

  1. Which version of Riot does it affect?

2.6.1

  1. How would you tag this issue?
    • Question
    • Bug
    • Discussion
    • Feature request
    • Tip
    • Enhancement
    • Performance
@ashleybrener
Contributor

Referencing #1897 by @5angel

@GianlucaGuarini
Member

This issue is already fixed in riot@next http://plnkr.co/edit/149mAO?p=preview and also discussed #1697

@GianlucaGuarini
Member

Ok sorry this is a bug! Properties in a parent tag should not be inherited unless children tags are in a loop

@GianlucaGuarini GianlucaGuarini added a commit that closed this issue Sep 18, 2016
@GianlucaGuarini GianlucaGuarini closes #1982 0df48e0
@GianlucaGuarini
Member

fixed in riot2.6.2 thank you!

@ashleybrener
Contributor

Thank you @GianlucaGuarini

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment