virtual with each doesn't remove tag references from parent tag #2029

Closed
moritzschepp opened this Issue Oct 17, 2016 · 0 comments

Projects

None yet

2 participants

@moritzschepp
  1. Describe your issue:

When the the virtual tag is used with each to create a series of <my-tag> for each element of some data, then this.tags['my-tag'] grows when the data receives more elements but it doesn't decrease when elements are removed.

BTW, if I iterate the tags directly without the virtual tag, the this.tags['my-tag'] doesn't take tags of the same name into account that are placed outside of the loop. This seems to be what #1519 is about, though. Just mentioning it because this was the reason why I switched to using virtual in the first place.

  1. Can you reproduce the issue?

https://jsfiddle.net/moritzschepp/7q979b1r/5/

(I'm having some issues with jsfiddle removing external resources. Make sure you check the console for the version of riot being used)

  1. On which browser/OS does the issue appear?

tried it on chromium 53.0.2785.143 (64-bit) and firefox 49.0.1, both don't work

  1. Which version of Riot does it affect?

This happens with 2.6.4 and 3.0.0-alpha.11

  1. How would you tag this issue?

Bug

@GianlucaGuarini GianlucaGuarini added this to the 3.0.0 milestone Oct 19, 2016
@GianlucaGuarini GianlucaGuarini added a commit that closed this issue Nov 22, 2016
@GianlucaGuarini GianlucaGuarini closes #2029 fe4fc33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment