Redraw depend from order #2040

Closed
cmplx opened this Issue Oct 25, 2016 · 6 comments

Projects

None yet

2 participants

@cmplx
cmplx commented Oct 25, 2016 edited

Help us to manage our issues by answering the following:

  1. Describe your issue:
    Faced with this problem, Riot updates the tag tree depending on the order in which the elements change. This applies only to complex tags such as iframe. In the example below, if you remove the end of the reload of the iframe is not happening, but if you remove the iframe from the beginning of the redrawn all the remaining elements. (Notice to redraw scroll to internal page )

I'm using riot in Electron project, and instead iframe using webview.

  1. Can you reproduce the issue?
    http://plnkr.co/edit/eUp8kjYeZDrlByD0IiTC?p=preview
  2. On which browser/OS does the issue appear?
    Chrome, Win7
  3. Which version of Riot does it affect?
    2.6.4
  4. How would you tag this issue?
    • Question
    • Bug
    • Discussion
    • Feature request
    • Tip
    • Enhancement
    • Performance
@GianlucaGuarini
Member

Use the no-reorder attribute that will just update your tags without trying to reorder them http://plnkr.co/edit/EtECmyaZ4iONbOxVikIM?p=preview

@cmplx
cmplx commented Oct 30, 2016 edited

Sorry, but this method also not working in this example http://plnkr.co/edit/GglkZ4V2XjDRNTw120qw?p=preview . I use 3 different site in an iframe , and the problem is the same. For me the problem was temporarily solved by manually removing it from the array of elements and a DOM element on the page, even after updating, redrawing the elements does not occur

@GianlucaGuarini GianlucaGuarini added bug and removed answered question labels Oct 30, 2016
@GianlucaGuarini
Member

@cmplx this seems to be a bug thanks!

@GianlucaGuarini GianlucaGuarini added this to the 3.0.0 milestone Oct 31, 2016
@GianlucaGuarini
Member

It seems this is a browser issue more than a riot one https://bugs.webkit.org/show_bug.cgi?id=13574, I am afraid we need mark this as wontfix. Honestly I don't know which one should be the right way to solve this issue

@GianlucaGuarini GianlucaGuarini added a commit that referenced this issue Oct 31, 2016
@GianlucaGuarini GianlucaGuarini closes #2040 95bf6f3
@GianlucaGuarini
Member

fixed ;) http://plnkr.co/edit/SgVsuFFU4fDsNMDwunGp?p=preview

I will try to bring this patch also in the next riot release

@GianlucaGuarini GianlucaGuarini removed this from the 3.0.0 milestone Oct 31, 2016
@GianlucaGuarini GianlucaGuarini added a commit that closed this issue Oct 31, 2016
@GianlucaGuarini GianlucaGuarini closes #2040 87694bf
@cmplx
cmplx commented Nov 1, 2016

Good work !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment