New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scope differs between `if` and `show` #2125

Closed
tamamachi opened this Issue Nov 30, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@tamamachi

tamamachi commented Nov 30, 2016

  1. Describe your issue:

You specify if conditions to the nested tag, and you can access to the variables of current tag inside the value expression of if.
However, If you use show instead of if, you cannot access to the variables of current tag inside the value expression.

This mismatch of behaviors is confusing.
I think the behavior of if might be the right one.

  1. Can you reproduce the issue?

https://jsfiddle.net/rvhk0n98/6/

  1. On which browser/OS does the issue appear?

Google Chrome for macOS 53.0.2785.143 (64-bit)

  1. Which version of Riot does it affect?

3.0.0
3.0.1

  1. How would you tag this issue?
  • Question
  • Bug
  • Discussion
  • Feature request
  • Tip
  • Enhancement
  • Performance
@GianlucaGuarini

This comment has been minimized.

Show comment
Hide comment
@GianlucaGuarini

GianlucaGuarini Dec 3, 2016

Member

I agree thanks this should be improved

Member

GianlucaGuarini commented Dec 3, 2016

I agree thanks this should be improved

@GianlucaGuarini GianlucaGuarini added the bug label Dec 3, 2016

@sourcegr

This comment has been minimized.

Show comment
Hide comment
@sourcegr

sourcegr Dec 7, 2016

This should be fixed soon, stumbled on it a lot of times allready...

It also confuses the users as to which is the right approach... Coding inconsistency is the number one reason to stop using a library

sourcegr commented Dec 7, 2016

This should be fixed soon, stumbled on it a lot of times allready...

It also confuses the users as to which is the right approach... Coding inconsistency is the number one reason to stop using a library

@GianlucaGuarini

This comment has been minimized.

Show comment
Hide comment
@GianlucaGuarini

GianlucaGuarini Jan 10, 2017

Member

this issue is not yet fixed my patch was creating other issues..I need to find a better solution for this problem

Member

GianlucaGuarini commented Jan 10, 2017

this issue is not yet fixed my patch was creating other issues..I need to find a better solution for this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment