Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with rollup.js starting with 3.0.6 - Part 2 #2224

Closed
btakita opened this issue Jan 15, 2017 · 2 comments
Closed

Incompatibility with rollup.js starting with 3.0.6 - Part 2 #2224

btakita opened this issue Jan 15, 2017 · 2 comments
Labels

Comments

@btakita
Copy link

@btakita btakita commented Jan 15, 2017

This is an open issue (for tracking purposes) to #2212.

I created this issue because #2212 is closed yet the bug still remains...

There is a fix at #2222

Thank you for developing riot. I need this bug fixed, as this causes an exception.

@btakita
Copy link
Author

@btakita btakita commented Jan 15, 2017

Here's the demonstration. Why don't you believe me that this is a bug?

https://github.com/btakita/riot-rollup-server-error

@btakita
Copy link
Author

@btakita btakita commented Jan 15, 2017

Here's the output. Note the _interopDefault function provided by rollup

https://github.com/btakita/riot-rollup-server-error/blob/master/dist/cjs.js

$ ./build.sh 

/home/phoenix/workspace/riot/riot-rollup-server-error/dist/cjs.js:7
if (!riot.render) throw 'riot.render does not exist'
                  ^
riot.render does not exist
GianlucaGuarini added a commit that referenced this issue Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.