Undefined not handled as empty string (in tags) #2297

Closed
fabien opened this Issue Mar 27, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@fabien
Contributor

fabien commented Mar 27, 2017

Help us to manage our issues by answering the following:

  1. Describe your issue:

According to the 3.4.0 Changelog:

Fix: Null and undefined expressions will be no longer converted into empty strings for the tag attributes riot/2180

The following template:

<h2>{ title } <small>{ regionName }</small></h2>

Produces this output (diff'd from test fixtures) after updating to 3.4.0:

-            <h2>RENDER DEMO <small>undefined</small></h2>
+            <h2>RENDER DEMO <small></small></h2>

Clearly, the noted Fix behavior is not limited to attributes, but affects expressions everywhere.

I'm also wondering, is riot/2180 actually the issue that has been resolved here?

  1. Can you reproduce the issue?

http://plnkr.co/edit/x6McIZl9iE7zsw2FN6a4?p=preview

  1. On which browser/OS does the issue appear?

N/A

  1. Which version of Riot does it affect?

3.4.0 specifically

  1. How would you tag this issue?
  • Question
  • Bug
  • Discussion
  • Feature request
  • Tip
  • Enhancement
  • Performance

@fabien fabien changed the title from Undefined not handled as empty string (in tags, not attributes) to Undefined not handled as empty string (in tags) Mar 27, 2017

@fabien

This comment has been minimized.

Show comment
Hide comment
@fabien

fabien Mar 27, 2017

Contributor

Here's the v.3.3.2 version for comparison:

http://plnkr.co/edit/yVp7HQp76bwKv05XQ6CZ?p=preview

Contributor

fabien commented Mar 27, 2017

Here's the v.3.3.2 version for comparison:

http://plnkr.co/edit/yVp7HQp76bwKv05XQ6CZ?p=preview

@fabien

This comment has been minimized.

Show comment
Hide comment
@fabien

fabien Mar 27, 2017

Contributor

Actual corresponding issue: #2080

Contributor

fabien commented Mar 27, 2017

Actual corresponding issue: #2080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment