Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Attributes not updating in v.3.4.4 #2343
I was seeing various issues that were initially hard to pinpoint. Since I still have yet to create an isolated plunkr, derived from a fairly complex setup, I will try to update this issue later.
I was able to make things work with the following changes in place, exactly like shown here:
What I was seeing:
The omission of
http://plnkr.co/edit/c4i4WiyLjHeXg8E96ppA?p=preview (v.3.4.4 - fails)
http://plnkr.co/edit/6TsSVHam1tgLsPwjJn73?p=preview (v.3.4.3 - works)
Chrome Mac, latest
@GianlucaGuarini here's a plunkr that clearly shows attributes not being updated, they are only set initially (note how they remain red, starting out from black):
What's interesting is that both changes were introduced following an issue I raised initially.
Like I said before, I respect all the work you put in, and still do.
However, given this, I'm keen to tread carefully in the future. There's a certain frailty that starts to worry me a bit, especially after having invested heavily in a Riot-based setup for my work. I will not discard Riot easily, I really enjoy using it. I'm just a bit careful now.
Also, I'd appreciate it if the
Another update, as I discovered this part of the issue is caused by a side-effect:
I was able to trace this back to the
A simulated setup shows what happened (using a selector with multiple fallbacks in jQuery, which is used from a mixin that cannot rely solely on
The other issue I raised, with (boolean) attributes not updating remains valid, and appears to be pretty serious.
The issue with your first plunkr might be just an html5 issue. The disabled attribute is, according to mdn, only supported on button, command, fieldset, input, keygen, optgroup, option, select and textarea elements, but not h2.
I've changed your plunkr to be html-compliant and it seems to just work as expected to me?
It's still html we're dealing with here, can't just go around doing stuff just because we want it to work. :)
@ramonakira thanks for your reply. I thought about the overlap with the html5 attribute
You changed from
Moreover, as you can see from the v.3.4.3 version, it simply worked as expected before.
I suspect that Riot handles native tags differently from custom ones, which might explain the difference in behavior.