New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"mount" event fired many times for single tag mount #2428

Closed
bminer opened this Issue Aug 22, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@bminer
Contributor

bminer commented Aug 22, 2017

  1. Describe your issue:
    The "mount" event is fired many times when a tag is mounted.
    This is probably a regression introduced in Riot 3.6.2. I cannot replicate this bug in Riot 3.6.1.

  2. Can you reproduce the issue?
    I will edit this comment and post a jsfiddle if I find extra time.

  3. On which browser/OS does the issue appear?
    Chromium 60.0.3112.78
    Linux Mint 18.1

  4. Which version of Riot does it affect?
    Riot 3.6.2. It does not affect Riot 3.6.1.

  5. How would you tag this issue?

  • Question
  • Bug
  • Discussion
  • Feature request
  • Tip
  • Enhancement
  • Performance
@bminer

This comment has been minimized.

Show comment
Hide comment
@bminer

bminer Aug 22, 2017

Contributor

Could be related to the fix for #2409?

Contributor

bminer commented Aug 22, 2017

Could be related to the fix for #2409?

@bminer

This comment has been minimized.

Show comment
Hide comment
@bminer

bminer Aug 22, 2017

Contributor

I think this happens when you call update() on the parent tag before the child tag mounts... still investigating...

Contributor

bminer commented Aug 22, 2017

I think this happens when you call update() on the parent tag before the child tag mounts... still investigating...

@bminer

This comment has been minimized.

Show comment
Hide comment
@bminer

bminer Aug 22, 2017

Contributor

Able to successfully duplicate: http://jsfiddle.net/65t6wzdd/

Contributor

bminer commented Aug 22, 2017

Able to successfully duplicate: http://jsfiddle.net/65t6wzdd/

@GianlucaGuarini GianlucaGuarini added bug and removed to verify labels Aug 22, 2017

GianlucaGuarini added a commit that referenced this issue Aug 22, 2017

GianlucaGuarini added a commit that referenced this issue Aug 23, 2017

Merge branch 'bug/2409' into dev
* bug/2409:
  fixed: #2409 and added tests for #2428 and #2409
@GianlucaGuarini

This comment has been minimized.

Show comment
Hide comment
@GianlucaGuarini

GianlucaGuarini Aug 23, 2017

Member

fixed in riot@3.6.3 thanks for reporting it

Member

GianlucaGuarini commented Aug 23, 2017

fixed in riot@3.6.3 thanks for reporting it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment