New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svg dynamic preserveAspectRatio don't work #2445

Closed
thaffe opened this Issue Sep 15, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@thaffe

thaffe commented Sep 15, 2017

It's impossible to use preserveAspectRatio="{ratio}".
Doing it without the riot prefix (preserveAspectRatio="{ratio}") throws error in chrome, and does not work in IE.
While doing it with the riot prefix ('riot-preserveAspectRatio="{ratio}") the attribute is converted to all lowercase, preserveaspectratio="none", which does not work in any browser.

@GianlucaGuarini GianlucaGuarini added question bug and removed question labels Sep 15, 2017

GianlucaGuarini added a commit that referenced this issue Sep 17, 2017

GianlucaGuarini added a commit that referenced this issue Sep 17, 2017

Merge branch 'feature/better-parent-child-inheritance' into dev
* feature/better-parent-child-inheritance:
  updated: faster loops and easier code
  closes #2445
  update: first attempt to fix the inheritance issues
  updated: simplify tags creation
  removed: unnecessary code to link parent children tags
@GianlucaGuarini

This comment has been minimized.

Show comment
Hide comment
@GianlucaGuarini

GianlucaGuarini Sep 23, 2017

Member

fixed in riot@3.7.2

Member

GianlucaGuarini commented Sep 23, 2017

fixed in riot@3.7.2

@fabien

This comment has been minimized.

Show comment
Hide comment
@fabien

fabien Nov 24, 2017

Contributor

Unfortunately, there are many more SVG attributes that are case-sensitive. I wonder if there's a more pragmatic approach to this, instead of listing each one individually.

Contributor

fabien commented Nov 24, 2017

Unfortunately, there are many more SVG attributes that are case-sensitive. I wonder if there's a more pragmatic approach to this, instead of listing each one individually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment