New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail to display nested custom tag in loop into SVG #2464

Closed
over80 opened this Issue Oct 11, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@over80

over80 commented Oct 11, 2017

  1. Describe your issue:

    in SVG context, simple nested tag:

     <g data-is='my-sub-tag' data={data}></g>
    

    works correctly.
    But use with each:

     <g data-is='my-sub-tag' data={data} each={data in data_array}></g>
    

    or

     <g each={data in data_array}>
       <g data-is='my-sub-tag' data={data}></g>
     </g>
    

    does not work.
    Contents of nested tag are surely inserted. But are not displayed as SVG.

  2. Can you reproduce the issue?

    http://jsfiddle.net/ffnoymzh/1/

    Red and yellow circle are not displayed.
    As shown in console,
    it seems contents of custom tag are not handled as SVG elements.

  3. On which browser/OS does the issue appear?

    • Google Chrome 61.0.3163.100 (Official Build) (64 bit) / Ubuntu 16.04
    • Firefox 56.0 (64 bit) / Ubuntu 16.04
    • Google Chrome 61.0.3163.100 (Official Build) (64 bit) / Windows 10
    • Microsoft Edge 40.15063.0.0 / Windows 10
  4. Which version of Riot does it affect?

    • current head of master branch (v3.7.3)
  5. How would you tag this issue?

    • Bug

GianlucaGuarini added a commit that referenced this issue Nov 4, 2017

@GianlucaGuarini GianlucaGuarini added fixed and removed fixed labels Nov 4, 2017

GianlucaGuarini added a commit that referenced this issue Nov 5, 2017

Merge branch 'bug/2464' into dev
* bug/2464:
  fixed: ie issues on svg tags and closes #2464
  updated: the failing tests
@over80

This comment has been minimized.

Show comment
Hide comment
@over80

over80 Nov 19, 2017

I reconfirm reproduction sample (and my app) with v3.7.4.
They works pretty well.
Thank you.

over80 commented Nov 19, 2017

I reconfirm reproduction sample (and my app) with v3.7.4.
They works pretty well.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment