New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles are left after unregister() #2576

Closed
karak opened this Issue Apr 18, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@karak
Contributor

karak commented Apr 18, 2018

Help us to manage our issues by answering the following:

  1. Describe your issue:

Riot injects the style sections of tags, and they remains after the tags are unregistered.

Yes, this is an edge case and rarely harmful except conflicts between UI frameworks or hard testing (as me).

  1. Can you reproduce the issue?

I created a test case and fixed in my fork at karak@74f38b0
But, I wonder why tag() didn't add css by name though tag2() did.
Can I send PR, or need some fix?

  1. On which browser/OS does the issue appear?

Node 9.9.0/Mac OS High Sierra

  1. Which version of Riot does it affect?

3.9.3

  1. How would you tag this issue?
  • Question
  • Bug
  • Discussion
  • Feature request
  • Tip
  • Enhancement
  • Performance
@GianlucaGuarini

This comment has been minimized.

Member

GianlucaGuarini commented Apr 19, 2018

fixed in riot@3.9.4 thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment