Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Riot 3.9.5 and up: Full unnecessary rerender with lost focus after state update #2585

Closed
1 of 7 tasks
dmitriyzhuk opened this issue May 12, 2018 · 2 comments
Closed
1 of 7 tasks

Comments

@dmitriyzhuk
Copy link

@dmitriyzhuk dmitriyzhuk commented May 12, 2018

  1. Describe your issue:
    After updating from RIOT 3.9.4 to 3.9.5 I have noticed that when ever I update one value in my state, my whole view is rerandered.

the code responsible for this is (line 2376)

var doReorder = mustReorder && typeof _item === T_OBJECT && !hasKeys;

to (line 2373)

var doReorder = mustReorder && typeof _item === T_OBJECT;

I wonder why was this edited and is it a bug or intended to work so. In my case, it is a bug since I have no need to rerander the whole view just by editing one state.
2. Can you reproduce the issue?

version 3.9.5 http://jsfiddle.net/5g2gpk5j/1/ - everything is rerendered and focus lost
version 3.9.4 http://jsfiddle.net/ojnkkzgz/1/ - only relevent divs are rerendered.

  1. On which browser/OS does the issue appear?
    tested on chrome
  2. Which version of Riot does it affect?
    3.9.5 and up
  3. How would you tag this issue?
  • Question
  • Bug
  • Discussion
  • Feature request
  • Tip
  • Enhancement
  • Performance
@GianlucaGuarini
Copy link
Member

@GianlucaGuarini GianlucaGuarini commented May 16, 2018

I need to investigate the issue because your demos are really too complex for a test case. I think I will be able to restore the backward compatibility in such an edge case. Thank you for submitting this issue

Loading

@dmitriyzhuk
Copy link
Author

@dmitriyzhuk dmitriyzhuk commented May 20, 2018

Thank you! much appreciated!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants