New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipAnonymousTags setting doesn't effect mount event in global mixin #2635

Closed
guzgu opened this Issue Oct 26, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@guzgu

guzgu commented Oct 26, 2018

  1. Describe your issue:
    Adding an mount event in global mixin won't trigger on anonymous tags even with skipAnonymousTags setting turned to false. Before-mount event will trigger. I think the reason is in set-mount-state.js
if (!isAnonymous) {
    if (value) this.trigger('mount')
    else {
      this.trigger('unmount')
      this.off('*')
      this.__.wasCreated = false
    }
  }

If statement should be (!skipAnonymous || !isAnonymous) instead.

  1. Can you reproduce the issue?

https://plnkr.co/edit/mKPEWMBBjtHmCqDObpV9?p=preview

  1. On which browser/OS does the issue appear?
    Chrome/win7

  2. Which version of Riot does it affect?
    3.7.0 =>

  3. How would you tag this issue?

  • Question
  • Bug
  • Discussion
  • Feature request
  • Tip
  • Enhancement
  • Performance
@GianlucaGuarini

This comment has been minimized.

Member

GianlucaGuarini commented Nov 1, 2018

fixed in riot@3.13.1 thank you for reporting it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment