Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipAnonymousTags setting doesn't effect mount event in global mixin #2635

Closed
1 of 7 tasks
guzgu opened this issue Oct 26, 2018 · 1 comment
Closed
1 of 7 tasks

skipAnonymousTags setting doesn't effect mount event in global mixin #2635

guzgu opened this issue Oct 26, 2018 · 1 comment

Comments

@guzgu
Copy link

@guzgu guzgu commented Oct 26, 2018

  1. Describe your issue:
    Adding an mount event in global mixin won't trigger on anonymous tags even with skipAnonymousTags setting turned to false. Before-mount event will trigger. I think the reason is in set-mount-state.js
if (!isAnonymous) {
    if (value) this.trigger('mount')
    else {
      this.trigger('unmount')
      this.off('*')
      this.__.wasCreated = false
    }
  }

If statement should be (!skipAnonymous || !isAnonymous) instead.

  1. Can you reproduce the issue?

https://plnkr.co/edit/mKPEWMBBjtHmCqDObpV9?p=preview

  1. On which browser/OS does the issue appear?
    Chrome/win7

  2. Which version of Riot does it affect?
    3.7.0 =>

  3. How would you tag this issue?

  • Question
  • Bug
  • Discussion
  • Feature request
  • Tip
  • Enhancement
  • Performance
@GianlucaGuarini
Copy link
Member

@GianlucaGuarini GianlucaGuarini commented Nov 1, 2018

fixed in riot@3.13.1 thank you for reporting it

Loading

GianlucaGuarini added a commit that referenced this issue May 30, 2019
* master: (266 commits)
  added: link to the new site
  Update issue templates
  Update issue templates
  Delete ISSUE_TEMPLATE.md
  Update issue templates
  Update issue templates
  removed: dead links from readme file
  fixed: unit test on async test
  3.13.2
  updated: dev dependencies
  fixes #2641
  updated: lock file
  3.13.1
  updated: lib size
  Added link to chrome extension boilerplate repository
  fixes #2635
  updated: lock file
  added: polymer 3 lib size
  3.13.0
  updated: framework sizes
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants