New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes SPM support #2124

Merged
merged 1 commit into from Dec 3, 2016

Conversation

Projects
None yet
3 participants
@cognitom
Member

cognitom commented Nov 30, 2016

  1. Have you added test(s) for your patch? If not, why not?
    No change on code.

  2. Can you provide an example of your patch in use?
    N/A

  3. Is this a breaking change?
    No.
    (Strictly speaking, could be yes. But spm seems died more than one year ago. Actually, no effect)

SPM support were introduced at this commit 6ecb24a, but SPM itself has discontinued 1 year ago.

spm 从 3.9 开始将不再管理组件的生命周期, 即不再有 spmjs.io. 所以相应的逻辑全部去除. 请使用 npm 来管理组件.

I can't read Chinese, sorry... here's the translation by Google Translate:

Spm Starting from 3.9 will no longer manage the lifecycle of the components, that is, spmjs.io is no longer available. So the corresponding logic is completely removed. Use npm to manage the components.

R.I.P.

@cognitom

This comment has been minimized.

Show comment
Hide comment
@cognitom

cognitom Nov 30, 2016

Member

@afc163 could you pls check it?
There's not so much information in English..., so I'm not sure about the status of SPM. I'll be happy if you would help us on it.

Member

cognitom commented Nov 30, 2016

@afc163 could you pls check it?
There's not so much information in English..., so I'm not sure about the status of SPM. I'll be happy if you would help us on it.

@afc163

This comment has been minimized.

Show comment
Hide comment
@afc163

afc163 Nov 30, 2016

Contributor

@afc163 Agree to remove it, cause spm is not maintained anymore. 😅

Contributor

afc163 commented Nov 30, 2016

@afc163 Agree to remove it, cause spm is not maintained anymore. 😅

@cognitom

This comment has been minimized.

Show comment
Hide comment
@cognitom

cognitom Nov 30, 2016

Member

@afc163 thanks for confirmation!
@riot/core-maintainers can I?

Member

cognitom commented Nov 30, 2016

@afc163 thanks for confirmation!
@riot/core-maintainers can I?

@GianlucaGuarini GianlucaGuarini merged commit 1814383 into dev Dec 3, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@GianlucaGuarini

This comment has been minimized.

Show comment
Hide comment
@GianlucaGuarini

GianlucaGuarini Dec 3, 2016

Member

@cognitom thanks for your pull request (honestly I have never heard about SPM)

Member

GianlucaGuarini commented Dec 3, 2016

@cognitom thanks for your pull request (honestly I have never heard about SPM)

@GianlucaGuarini GianlucaGuarini deleted the remove-spm branch Jan 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment