New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed rollup server side (cjs) transpilation. #2225

Closed
wants to merge 1 commit into
base: dev
from

Conversation

Projects
None yet
2 participants
@btakita
Copy link

btakita commented Jan 15, 2017

@btakita

This comment has been minimized.

Copy link

btakita commented Jan 15, 2017

Simply deleting .default seems to make this work with _interopDefault

@btakita btakita force-pushed the btakita:dev branch from 1a8568c to debea4a Jan 15, 2017

@btakita

This comment has been minimized.

Copy link

btakita commented Jan 15, 2017

I force pushed a change to remove exports.default = as it has no observable effect...

@btakita btakita force-pushed the btakita:dev branch from debea4a to 54d05cd Jan 15, 2017

@GianlucaGuarini

This comment has been minimized.

Copy link
Member

GianlucaGuarini commented Jan 15, 2017

my patch here should fix the issue thanks for pointing it out. Rollup assumes that riot.default was the default export for the commonjs bunlde but it's not what we want. In commonjs environments riot must be required with require('riot') we are not responsible of all the other wrappers around the node require method. However deleting the riot.default key from the common js distribution seems to solve the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment