Fixed rollup server side (cjs) transpilation. #2225

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@btakita

btakita commented Jan 15, 2017

@btakita

This comment has been minimized.

Show comment
Hide comment
@btakita

btakita Jan 15, 2017

Simply deleting .default seems to make this work with _interopDefault

btakita commented Jan 15, 2017

Simply deleting .default seems to make this work with _interopDefault

@btakita

This comment has been minimized.

Show comment
Hide comment
@btakita

btakita Jan 15, 2017

I force pushed a change to remove exports.default = as it has no observable effect...

btakita commented Jan 15, 2017

I force pushed a change to remove exports.default = as it has no observable effect...

@GianlucaGuarini

This comment has been minimized.

Show comment
Hide comment
@GianlucaGuarini

GianlucaGuarini Jan 15, 2017

Member

my patch here should fix the issue thanks for pointing it out. Rollup assumes that riot.default was the default export for the commonjs bunlde but it's not what we want. In commonjs environments riot must be required with require('riot') we are not responsible of all the other wrappers around the node require method. However deleting the riot.default key from the common js distribution seems to solve the issue

Member

GianlucaGuarini commented Jan 15, 2017

my patch here should fix the issue thanks for pointing it out. Rollup assumes that riot.default was the default export for the commonjs bunlde but it's not what we want. In commonjs environments riot must be required with require('riot') we are not responsible of all the other wrappers around the node require method. However deleting the riot.default key from the common js distribution seems to solve the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment