New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parentnode check on virtual replace #2615

Merged
merged 3 commits into from Aug 29, 2018

Conversation

Projects
None yet
3 participants
@casmit
Contributor

casmit commented Jul 25, 2018

IMPORTANT: for all the pull requests use the dev branch

Answer the following depending on the type of change you want to merge

Code

  1. Have you added test(s) for your patch? If not, why not?

  2. Can you provide an example of your patch in use?

Post the link using one of our bug report templates:

  1. Is this a breaking change?

Content

Provide a short description about what you have changed: Makes a basic check on presence of ref.parentNode before continuing with execution of virtual tag replacement.

#2614

Chris Smit Chris Smit
@GianlucaGuarini

This comment has been minimized.

Member

GianlucaGuarini commented Aug 4, 2018

thank you. Could you please provide a test as well? This will help avoiding this issue in future

@GianlucaGuarini GianlucaGuarini self-requested a review Aug 4, 2018

Adrian and others added some commits Aug 20, 2018

Merge pull request #1 from adrian-enspired/smit
fix makeReplaceVirtual in source; add spec

@GianlucaGuarini GianlucaGuarini self-assigned this Aug 21, 2018

@robertology

I also would like to see this merged. We're seeing breakage after certain things get unmounted, so the sooner the better.

Looks like a safe change to merge in too. A quick check if ref.parentNode exists seems reasonable.

@GianlucaGuarini GianlucaGuarini changed the base branch from master to dev Aug 28, 2018

@GianlucaGuarini GianlucaGuarini merged commit 61f62fb into riot:dev Aug 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@GianlucaGuarini

This comment has been minimized.

Member

GianlucaGuarini commented Aug 29, 2018

thank you for your patch. I will release a patched riot version asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment