Routing priority broken #63

Closed
gdub22 opened this Issue Jul 14, 2016 · 6 comments

Projects

None yet

4 participants

@gdub22
Contributor
gdub22 commented Jul 14, 2016

Previously, when a match is found, no other routes are triggered. Now multiple routes are firing.

I noticed this updating from riot 2.3.18 -> 2.5.0.
It appears to be caused by changes in riot observable, because it works correctly if I roll that back. Nothing in this route repo has changed in a while.


Example:

route('/post/*.amp.html', function() { /* */ })
route('/post/*', function() { /* */ })

Given the url: /post/title-of-my-post
The expected result is for the second route to trigger.
The actual result is both get triggered, and also appears to be a race condition of which one gets triggered first.

@GianlucaGuarini
Member

@cognitom could you please have a look?

@GianlucaGuarini GianlucaGuarini added bug and removed to verify labels Jul 24, 2016
@GianlucaGuarini
Member

Ah I guess it's the events namespacing the problem. I think we need either to remove the namespaced events or simply normalize them inside the router

@cognitom
Member

@GianlucaGuarini thanks!
Ah, "name spaced" and "namespacing", finally understood what happened 😲

@GianlucaGuarini
Member

@cognitom oups my typo 😄

@artstar
artstar commented Aug 24, 2016 edited

So good feature was removed:(
Are there any plans to add event namespacing back?

@GianlucaGuarini
Member

@artstar no we are removing the fat from riot and events namespacing was causing performance issues and other several issues in the router. If you want to use this feature i guess you can do it with probably 10 lines of code in a mixin. Let me know if you need help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment