Fix sub-route termination #52

merged 1 commit into from Mar 8, 2016


None yet

3 participants

chmanie commented Feb 4, 2016

This should fix #51.

I shamelessly copied the test code from #51 (comment) (thanks, @wiz).

Instead of just returning a function that loses the object context of itself, now the stop() function directly sits on the instance.


cool thanks @chmanie

chmanie commented Feb 8, 2016

I think this still doesn't work. It seems to stop the main router as well. Can you confirm?


@cognitom could you verify this pull request please?

wiz commented Feb 12, 2016

It seems to stop the main router as well. Can you confirm?

Just stumbled into this while registering another subroute. Apparently something somewhere else in my app was silently "fixing" this so I haven't noticed at once.


@cognitom can you merge please the pull requests so we can make a new riot release updating the router as well

@GianlucaGuarini GianlucaGuarini merged commit 6afede7 into riot:master Mar 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment