Fix sub-route termination #52

Merged
merged 1 commit into from Mar 8, 2016

Projects

None yet

3 participants

@chmanie
Contributor
chmanie commented Feb 4, 2016

This should fix #51.

I shamelessly copied the test code from #51 (comment) (thanks, @wiz).

Instead of just returning a function that loses the object context of itself, now the stop() function directly sits on the instance.

@GianlucaGuarini
Member

cool thanks @chmanie

@chmanie
Contributor
chmanie commented Feb 8, 2016

I think this still doesn't work. It seems to stop the main router as well. Can you confirm?

@GianlucaGuarini
Member

@cognitom could you verify this pull request please?

@wiz
wiz commented Feb 12, 2016

It seems to stop the main router as well. Can you confirm?

Just stumbled into this while registering another subroute. Apparently something somewhere else in my app was silently "fixing" this so I haven't noticed at once.

@GianlucaGuarini
Member

@cognitom can you merge please the pull requests so we can make a new riot release updating the router as well

@GianlucaGuarini GianlucaGuarini merged commit 6afede7 into riot:master Mar 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment