In this branch, I've updated GDash to use the latest version of bootstrap and jquery (with server-side compiled less).
I also replaced the table-based HTML markup with the bootstrap thumbnail gallery, and included the bootstrap responsive design component with the default bootstrap breakpoints.
In removing the tables, I also changed the code to use the .graph filename in the graph permalink, rather than the array index.
update to bootstrap 2.x and render the bootstrap less on the server-side
use graph name as a permalink
use bootstrap-responsive design on dashboards
refactor graph rendering into a separate graph partial
use graph_column configuration setting to adjust the graph's span class
@ripienaar Any chance of getting this pull request and others merged in? I noticed that there are a few gdash forks that have evolved quite a bit and am wondering what the goals are for this master repository.
@powdahound well I guess as is often the case with opensource I do not currently have the problem gdash solves anymore so giving it the love it deserves is basically a time and infrastructure problem.
A PR like this requires a fair bit of testing and now some refactoring to make work, some time ago someone offered their help in becoming a maintainer for gdash, I was happy with this idea but ultimately it came to naught.
For now I guess I'd need people to at the very least help test big PRs like this which might end up causing breakage as that's the main time constraint I have and hopefully we might end up with a group who maintain it. I know gdash is widely loved and forked but just do not have the time at present :(
Understood. Perhaps @ojilles would be interested in helping? His fork seems to be very active.
Hi, would love to help but a) I'm working towards some other functional goals and b) i'm sorely lacking time! Happy to share what I have, but unless you get me baby sitter, won't be able to free up time to help on this particular task.
Bummer. Are you both using other dashboard tools now or are you no longer using Graphite at all? This project seemed like the most promising.
I use graphite but gdash was always ment to be a simple single function tool so it more or less does what I want. Also I used gdash while I still maintained customer machines now I am in a development position so for me the problem more or less just went away
The one feature I want to add is a munin like view.
@powdahound We actively use graphite and gdash it in our project. Using our branch for include graphs in templates, we got a small script that generates dash.yaml for each environment and role. We will try to implement a improved version of the nagios plugin.
Other interesting features that we would like to implement are:
Oops! Meant to reply here sooner. We'd be very happy to contribute improvements, especially to the UI where we are most familiar. Do you think you are in a position to be a gatekeeper for the project? It seems like quite a few people are actively working on it but their efforts are all stuck in their own forks 😦.
As far as I know I don't have kids, so my only problem can be indolence and no proficiency with ruby and web programming .
But sure, I can try to keep care of pull requests. Specially when we are actively using it in the office.
I'd be happy to give more people committer rights to the repo, ideally more than 1 so we can have a process of only merging changes that had a +1 from another committer
I'm actively using and managing my own fork as well. I'd be happy to participate in maintaining this repo.
OK - the thing we'd need is at least 2 people who +1 a commit and given that someone can merge, we've had 2 people saying they are keen - @bwhaley and @keymon
Keen to do it, but also keen not to have just one other dude, any thoughts or views?
I'm happy to help test pulls since we're actively using gdash but can't guarantee I'll always be incredibly responsive.
The same here. I can help merging the requests and voting.
Seems like three active or semi-active maintainers (myself, @keymon, @powdahound) is enough to keep the project going, especially with occasional guidance from @ripienaar.
Also, this project is coupled with the graphite_graph DSL. Those of us maintaining it need to keep an eye on that project as well and may need to submit fixes/feature enhancements occasionally. That project already has two maintainers, at least according to the gem info (RIP and Tom Taylor).
RIP, do you have any thoughts or concerns about moving forward with this?
no concerns, pick a PR - review it and +1, once there are more than 1 +1 I'll hand out commit rights.
happy to help set up discussion lists if you want or whatever
Anyone have a pull they're especially passionate about? If not, how about this one? Looks like a worthwhile improvement.
This PR looks good to me after a few updates to catch up to master. Tested in my own fork bwhaley/gdash@5c18250
I've added @powdahound @keymon @bwhaley and @falkenbt as contributors so feel free to merge and let me know if you need more/fewer etc please
Thanks, everyone, for keeping this project alive. Wouldn't mind having a second pair of eyes to sanity check as this is my first merge on the project.
Thanks @bwhaley. apologies for not being more active on this PR, so many thanks for shepherding this into master.