Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

Commit

Permalink
Merge pull request #44 from prashanthrajagopal/master
Browse files Browse the repository at this point in the history
Fix for data[target] having nil
  • Loading branch information
ripienaar committed Sep 13, 2013
2 parents fd89b46 + 3168178 commit 4f38b10
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions bin/check_graph.rb
Expand Up @@ -52,25 +52,26 @@ def check_data(data, min, max)
fails = []

data.keys.each do |target|
data["#{target}"].compact!
if min == max # we got just one value to compare against
if min < 0
# if the threshold is < 0 we check for values below the threshold but have no way to say that
# critical / warning is above -0.5 for example unless you specify a 2 value band
if (data[target].min <= min)
fails << {:target => target, :item => data[target].min, :operator => "<=", :expected => min}
if (data["#{target}"].min <= min)
fails << {:target => target, :item => data["#{target}"].min, :operator => "<=", :expected => min}
end
else
if (data[target].max >= max)
fails << {:target => target, :item => data[target].max, :operator => ">=", :expected => max}
if (data["#{target}"].max >= max)
fails << {:target => target, :item => data["#{target}"].max, :operator => ">=", :expected => max}
end
end
else # we have a range of values to compare against and the values must be between
if (data[target].min <= min)
fails << {:target => target, :item => data[target].min, :operator => "<=", :expected => min}
if (data["#{target}"].min <= min)
fails << {:target => target, :item => data["#{target}"].min, :operator => "<=", :expected => min}
end

if (data[target].max >= max)
fails << {:target => target, :item => data[target].max, :operator => ">=", :expected => max}
if (data["#{target}"].max >= max)
fails << {:target => target, :item => data["#{target}"].max, :operator => ">=", :expected => max}
end
end
end
Expand Down

0 comments on commit 4f38b10

Please sign in to comment.